[Bug 3964] Review request: qtav - A media playback framework based on Qt and FFmpeg

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3964

--- Comment #3 from Antonio Trande <anto.trande at gmail.com> 2016-02-05 22:29:47 CET ---
(In reply to comment #0)
> Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qtav.spec
> SRPM URL:
> https://martinkg.fedorapeople.org/Review/SRPMS/qtav-1.9.0-0.1gitfafd3b0.fc23.src.rpm
> 

- Does not build because missing BR (desktop-file-utils).

- Release: 0.1git%{shortcommit0}%{?dist}

This is uncorrect for me: if it's a pre-release, should be:

Release: 0.1.git%{shortcommit0}%{?dist}
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

- Why it is compiled with clang++ ?

- Optimization flags are not honored.
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.