[Bug 3863] Review request: game-data-packager - Installer for game data files
RPM Fusion Bugzilla
noreply at rpmfusion.org
Sat Jan 2 12:32:19 CET 2016
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863
Hans de Goede <j.w.r.degoede at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--- Comment #14 from Hans de Goede <j.w.r.degoede at gmail.com> 2016-01-02 12:32:19 CET ---
Good:
=====
- rpmlint checks return:
game-data-packager.src: W: invalid-url Source0:
game-data-packager-20151231.tar.gz
This is normal for a snapshot pkg, ignore
game-data-packager.noarch: E: zero-length
/etc/game-data-packager/quake3-mirrors
I assume this is intentional and thus can also be ignored ?
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2 and GPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
Everything looks good to me: Approved.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the rpmfusion-developers
mailing list