[Bug 3912] Review request: lives - Video editor and VJ tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3912

--- Comment #29 from Sérgio Basto <sergio at serjux.com> 2016-01-13 21:12:38 CET ---
Created attachment 1541
  --> https://bugzilla.rpmfusion.org/attachment.cgi?id=1541
lives.dmitry.spec

(In reply to comment #28)
> SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
> SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-6.fc23.src.rpm
> 
> - Update from revision 2353
> - libvisual support disabled
> 
> @Sergio
> I think this is defintive release ready for review.

Hello , I have one previous .spec ( lives.dmitry.spec ) and you miss some
scripts, but first talk about LiVES.appdata.xml , shouldn't be in spec ! we
should upstream , or add as a file to upstream it later . 
Source1: LiVES.appdata.xml
install -Dp %{SOURCE1} $RPM_BUILD_ROOT/%{_datadir}/appdata/LiVES.appdata.xml

I think you should use desktop-file-install :
-desktop-file-edit \
+desktop-file-install \

we could add some doc:
 %files -f %{name}.lang
 %doc README AUTHORS BUGS ChangeLog FEATURES
+%doc GETTING.STARTED NEWS OMC/*.txt RFX/*

you also miss , I think not sure ldconfig and update-desktop-database

%post -p /sbin/ldconfig
update-desktop-database &> /dev/null || :

%postun -p /sbin/ldconfig
update-desktop-database &> /dev/null || :

All others things are good and ready to be approved . 
Thanks.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.