[Bug 3912] Review request: lives - Video editor and VJ tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3912

--- Comment #31 from Antonio Trande <anto.trande at gmail.com> 2016-01-13 22:10:22 CET ---
(In reply to comment #29)
> Created attachment 1541 [details]
> lives.dmitry.spec
> 
> (In reply to comment #28)
> > SPEC: https://sagitter.fedorapeople.org/lives/lives.spec
> > SRPM: https://sagitter.fedorapeople.org/lives/lives-2.4.6-6.fc23.src.rpm
> > 
> > - Update from revision 2353
> > - libvisual support disabled
> > 
> > @Sergio
> > I think this is defintive release ready for review.
> 
> Hello , I have one previous .spec ( lives.dmitry.spec ) and you miss some
> scripts, but first talk about LiVES.appdata.xml , shouldn't be in spec ! we
> should upstream , or add as a file to upstream it later . 
> Source1: LiVES.appdata.xml
> install -Dp %{SOURCE1} $RPM_BUILD_ROOT/%{_datadir}/appdata/LiVES.appdata.xml

Well, there is not any original appdata-file in source archive from upstream, I
made one directly. Nothing prevents me to make an appdata file during building
(see
https://fedoraproject.org/wiki/Packaging:AppData#.appdata.xml_file_creation).
Of course, if upstream maintainer (in copy in this ticket) wishes to include it
and use his own screeshots, better.

> 
> I think you should use desktop-file-install :
> -desktop-file-edit \
> +desktop-file-install \

Why? desktop-file-edit and desktop-file-install are almost same command. See
'man desktop-file-edit'

> 
> we could add some doc:
>  %files -f %{name}.lang
>  %doc README AUTHORS BUGS ChangeLog FEATURES
> +%doc GETTING.STARTED NEWS OMC/*.txt RFX/*

Okay.

> 
> you also miss , I think not sure ldconfig and update-desktop-database
> 
> %post -p /sbin/ldconfig
> update-desktop-database &> /dev/null || :
> 
> %postun -p /sbin/ldconfig
> update-desktop-database &> /dev/null || :
> 

ldconfig is invoked when libraries are shared, so installed in /usr/lib
directory; libweed are private libraries, installed in a /usr/lib sub-directory
and used by LiVES only. (See
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries)

lives.desktop has not a MimeType key; why should I invoke
update-desktop-database? 
(http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database)

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.