[Bug 118] Review Request: cinelerra-cv - Advanced audio and video capturing, compositing, and editing

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=118

--- Comment #54 from Antonio Trande <anto.trande at gmail.com> 2016-01-15 20:36:15 CET ---
Created attachment 1545
  --> https://bugzilla.rpmfusion.org/attachment.cgi?id=1545
Proposed spec file

(In reply to comment #52)
> 
> - AutoTools: Obsoleted m4s found
>   AC_PROG_LIBTOOL found in: cinelerra-cv-2.3/configure.ac:94
>   See https://fedorahosted.org/FedoraReview/wiki/AutoTools
> 
> - Why are execstack commands not executed?
> 
> - unused-direct-shlib-dependency warnings
>   See
> https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainers/Common_Rpmlint_Issues#unused-direct-shlib-dependency
> 
> - undefined-non-weak-symbol /usr/lib64/libguicast.so.1.0.0 
>   Probably, needs a link to the libquicktimehv library
> 
> 
> - %global __global_ldflags %(echo %{__global_ldflags} | sed
> 's/-specs=.*hardened-ld//' )
>   Why?
> 

I seen hardened-ld breaks linkage. I have done some change to your spec file
and added a patch: hardened definitions are activated and all hardened flags
honored now.

Just a issue: some library-not-linked-against-libc errors but they seem false
positive.  

> - non-conffile-in-etc /etc/sysctl.d/cinelerra-cv.conf
>   See
> https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainers/Common_Rpmlint_Issues#non-conffile-in-etc

See also
http://fedoraproject.org/wiki/Packaging:Guidelines#binfmt.d.2C_sysctl.d_and_tmpfiles.d

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.