[Bug 4159] Review request: tvheadend - TV streaming server and digital video recorder

RPM Fusion Bugzilla noreply at rpmfusion.org
Sat Jul 30 12:52:46 CEST 2016 

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4159

MartinKG <mgansser at alice.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |4

--- Comment #5 from MartinKG <mgansser at alice.de> 2016-07-30 12:52:46 CEST ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues solved:
==================
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gzip bzip2 gcc
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

  False-positive issue. fedora-review is not up-to-date with latest guidelines
updates

  According to
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B?rd=C_and_C
  "If your application is a C or C++ application you must list a BuildRequires
  against gcc, gcc-c++ or clang"

- W: crypto-policy-non-compliance-openssl
  https://fedoraproject.org/wiki/Packaging:CryptoPolicies

- W: non-standard-uid /var/lib/tvheadend tvheadend
  %attr(-,%{tvheadend_user},%{tvheadend_group}) %dir
%{_sharedstatedir}/%{tvheadend_user}/
  is used in rpm spec file, is ok.

- E: zero-length /usr/share/tvheadend/src/webui/static/lovcombo/css/empty.css
  file is required, can be ignored.

- E: incorrect-fsf-address
  was reported upstream, ok.

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.


Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "GPL (v2 or later)", "GPL (v3 or later)",
     "Unknown or generated", "GPL (v3.0)", "MIT/X11 (BSD like)", "*No
     copyright* GPL (v3 or later)", "GPL (v2 or later) (with incorrect FSF
     address)", "LGPL (v2.1 or later)", "GPL (v3)", "GPL (v3 or later)
     (with incorrect FSF address) LGPL (v3 or later) (with incorrect FSF
     address)", "*No copyright* LGPL (v2 or later) (with incorrect FSF
     address)". 2449 files have unknown license. Detailed output of
     licensecheck in /home/martin/rpmbuild/SPECS/tvheadend/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     tvheadend-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 4167680 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: tvheadend-4.0.9-1.fc25.x86_64.rpm
          tvheadend-debuginfo-4.0.9-1.fc25.x86_64.rpm
          tvheadend-4.0.9-1.fc25.src.rpm
tvheadend.x86_64: W: spelling-error %description -l en_US ffmpeg -> MPEG
tvheadend.x86_64: W: spelling-error %description -l en_US libav -> lib av,
lib-av, Libya
tvheadend.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/tvheadend
SSL_CTX_set_cipher_list
tvheadend.x86_64: W: non-standard-uid /var/lib/tvheadend tvheadend
tvheadend.x86_64: E: zero-length
/usr/share/tvheadend/src/webui/static/lovcombo/css/empty.css
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/stream.c
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/FFdecsa.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/FFdecsa.c
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/parallel_064_mmx.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/parallel_128_sse2.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/fftable.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/parallel_032_int.h
tvheadend.src: W: spelling-error %description -l en_US ffmpeg -> MPEG
tvheadend.src: W: spelling-error %description -l en_US libav -> lib av, lib-av,
Libya
3 packages and 0 specfiles checked; 8 errors, 6 warnings.




Rpmlint (debuginfo)
-------------------
Checking: tvheadend-debuginfo-4.0.9-1.fc25.x86_64.rpm


tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/parallel_064_mmx.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/parallel_032_int.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/stream.c
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/FFdecsa.c
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/fftable.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/parallel_128_sse2.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/FFdecsa.h
1 packages and 0 specfiles checked; 7 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/FFdecsa.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/parallel_064_mmx.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/parallel_032_int.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/fftable.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/parallel_128_sse2.h
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/FFdecsa.c
tvheadend-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tvheadend-4.0.9/src/descrambler/ffdecsa/stream.c
tvheadend.x86_64: W: spelling-error %description -l en_US ffmpeg -> MPEG
tvheadend.x86_64: W: spelling-error %description -l en_US libav -> lib av,
lib-av, Libya
tvheadend.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/tvheadend
SSL_CTX_set_cipher_list
tvheadend.x86_64: W: non-standard-uid /var/lib/tvheadend tvheadend
tvheadend.x86_64: E: zero-length
/usr/share/tvheadend/src/webui/static/lovcombo/css/empty.css
2 packages and 0 specfiles checked; 8 errors, 4 warnings.



Requires
--------
tvheadend-debuginfo (rpmlib, GLIBC filtered):

tvheadend (rpmlib, GLIBC filtered):
    /bin/sh
    config(tvheadend)
    dtv-scan-tables
    libavahi-client.so.3()(64bit)
    libavahi-common.so.3()(64bit)
    libavcodec.so.57()(64bit)
    libavcodec.so.57(LIBAVCODEC_57)(64bit)
    libavfilter.so.6()(64bit)
    libavfilter.so.6(LIBAVFILTER_6)(64bit)
    libavformat.so.57()(64bit)
    libavformat.so.57(LIBAVFORMAT_57)(64bit)
    libavresample.so.3()(64bit)
    libavresample.so.3(LIBAVRESAMPLE_3)(64bit)
    libavutil.so.55()(64bit)
    libavutil.so.55(LIBAVUTIL_55)(64bit)
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libcrypto.so.10(libcrypto.so.10)(64bit)
    libdbus-1.so.3()(64bit)
    libdbus-1.so.3(LIBDBUS_1_3)(64bit)
    libdl.so.2()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libhdhomerun.so()(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    librt.so.1()(64bit)
    libssl.so.10()(64bit)
    libssl.so.10(libssl.so.10)(64bit)
    liburiparser.so.1()(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)
    systemd



Provides
--------
tvheadend-debuginfo:
    tvheadend-debuginfo
    tvheadend-debuginfo(x86-64)

tvheadend:
    bundled(extjs)
    config(tvheadend)
    tvheadend
    tvheadend(x86-64)



Source checksums
----------------
https://github.com/tvheadend/tvheadend/archive/v4.0.9/tvheadend-4.0.9.tar.gz :
  CHECKSUM(SHA256) this package     :
cea1106f45e286e8c25e6b2f0a581c28bd85e93ce3801ecaac7041568a214977
  CHECKSUM(SHA256) upstream package :
cea1106f45e286e8c25e6b2f0a581c28bd85e93ce3801ecaac7041568a214977


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64-rpmfusion_free
-rn ../SRPMS/tvheadend-4.0.9-1.fc24.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6


PACKAGE APPROVED

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the rpmfusion-developers mailing list