[Bug 4256] Review request: aegisub - Tool for creating and modifying subtitles

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=4256

Vasiliy Glazov <vascom2 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vascom2 at gmail.com

--- Comment #1 from Vasiliy Glazov <vascom2 at gmail.com> ---
1. Remove
%global         gituser         Aegisub
%global         gitname         Aegisub
And use %{url instead of https://github.com/%{gituser}/%{gitname} in Source0.

2. Change
%autosetup -n %{gitname}-%{version} -p 1
to
%autosetup -n Aegisub-%{version} -p 1

It is not so often used to make %global macro.

3. Remove rm -rf %{buildroot}.

4. Make desktop-file validation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.rpmfusion.org/pipermail/rpmfusion-developers/attachments/20160921/a28a2d71/attachment.html>