Hi,<br><br><div class="gmail_quote">On Mon, Sep 3, 2012 at 6:51 PM, Nicolas Chauvet <span dir="ltr"><<a href="mailto:kwizart@gmail.com" target="_blank">kwizart@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
2012/9/3 Giles <<a href="mailto:gbirchley@blueyonder.co.uk">gbirchley@blueyonder.co.uk</a>>:<br>
<div><div class="h5">> Hi,<br>
><br>
> I'm trying to make a package pcsx2, a playstation2 emulator, for Fedora to<br>
> be included on the rpmfusion repository. (Bug 2455 - Review request: pcsx2 -<br>
> A Sony Playstation2 emulator).<br>
> I have run into problems as I have removed the SSE and SSE2 cflags and now<br>
> the package does not build. I am being given some advice by another<br>
> packager, who thinks this may disqualify the package from rpmfusion. Is<br>
> there any way to include a package with such dependencies in the repository?<br>
<br></div></div></blockquote><div>I'm the one who suggested Giles to write here.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
</div></div>I don't know any guideline that would prevent this ?<br>
But someone could point it to me.<br></blockquote><div><br>Not all i686 arch supported by Fedora have SSE or SSE2 capabilities. AFAIK some of the %{optflags} were selected to match these architectures. Hence someone could install a package that won't work on his PC if you enable SSE and SSE2 flags.<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Using runtime detection would be expected in nowadays code, but if the<br>
default implementation is sse/sse2 this couldn't be expected by<br>
default on i686, whereas this is always present on x86_64 (and maybe<br>
ia64 if relevant).<br></blockquote><div><br>ATM the package in question won't even build without SSE and SSE2 flags and it can't be compiled on x86_64.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I don't see any point to use ExclusiveArch: x86_64 that would prevent<br>
some i686 users because of that.<br></blockquote><div><br>Since it cannot be compiled on x86_64, the packages is ExclusiveArch: i686<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Also I would compare with 3D card, you will likely hit a hardware<br>
limitation somewhere if you load a huge 3D CAD model on an Intel IGP<br>
with an Atom CPU, this will crash early somewhere.<br>
So in your case, if you disable sse2, you may lower the level of such<br>
hardware limitation, because then sse2 capable CPU may not be able to<br>
run the software appropriately with sse1 only CPU already too short<br>
for this emulation anyway.<br>
<br>
So I would prefer to have a simple check on i686 for sse2 capability<br>
as an entry point instead of disabling sse2 and have sse2 capable CPU<br>
to behave like sse1 only one and not been able to run the software<br>
whereas they should have.<br></blockquote><div><br>I agree. A check with upstream can be enlightening :-)<br><br>Bye,<br><br>Andrea.<br> <br></div></div>