<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2013/11/22 Alec Leamas <span dir="ltr"><<a href="mailto:leamas.alec@gmail.com" target="_blank">leamas.alec@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
With the lpf package under way to fedora stable and the first lpf-* packages on their way into rpmfusion there is an issue with the review process fo llpf-* packages (an lpf package).<br>
<br>
An lpf package is basically a wrapper for the spec for a target package. E. g. lpf-skype contains lpf.skype.spec and <a href="http://skype.spec.in" target="_blank">skype.spec.in</a> (see [1]).<br>
<br>
Formally, when reviewing the lpf-skype package a reviewer should review the package spec i. e., lpf-skype.spec. However, this is just some copy-paste code which is more or less the same for all lpf packages. It's still evolving, but it should be more or less a non-issue when reviewing.<br>
</blockquote></div>The only issue I expect is when the package is only available for a subset of architectures, Given that it's often pre-build binaries, I guess most lft packages should be made ExclusiveArch to match<br>
<br></div><div class="gmail_extra">I have no problem having to say the the real review is the bundled <a href="http://spec.in">spec.in</a> that's been said.<br></div><div class="gmail_extra">I should be common sense that guidelines should en-light.<br>
<br></div><div class="gmail_extra">Unrelated question. Can lpf be made to rebuild existing packages from src.rpm (provided as sources repositories) using --with --without RPM conditionals ? I think it would be very usefull.<br>
</div><div class="gmail_extra">Also, when I first thought about a feature like lpf; I expected non-redistributable softwares to be provided as nosrc.rpm from the source code repository instead. (so handled like any others packages in SCM)...<br>
</div><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Nicolas (kwizart)<br></div></div>