<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jul 7, 2016 at 2:01 PM, Ben Rosser <span dir="ltr"><<a href="mailto:rosser.bjr@gmail.com" target="_blank">rosser.bjr@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div class="h5"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jul 6, 2016 at 11:52 PM, Ben Rosser <span dir="ltr"><<a href="mailto:rosser.bjr@gmail.com" target="_blank">rosser.bjr@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span>On Wed, Jul 6, 2016 at 5:44 PM, Nicolas Chauvet <span dir="ltr"><<a href="mailto:kwizart@gmail.com" target="_blank">kwizart@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">- rfpkg needs to be removed from the default buildroot and use<br>
rfpkg-minimal instead.<br>
This is a simple task that anyone can take. (convert and create<br>
rfpkg-minimal rpm package based on fedpkg-minimal)<br></blockquote><div><br></div></span><div>I just took a look at this, since it sounded like something I might be able to do. fedpkg-minimal is pretty straightforward: <a href="https://git.fedorahosted.org/cgit/fedpkg-minimal.git/tree/bin/fedpkg" target="_blank">https://git.fedorahosted.org/cgit/fedpkg-minimal.git/tree/bin/fedpkg</a></div><div><br></div><div>Unfortunately, an RPM Fusion equivalent will need to know whether or not the package in question is in free/ or in nonfree/, because of the dist-git namespacing. e.g. the curl line should become "$baseurl/free/$pkgname/$tarball/$md5sum/$tarball" or "$baseurl/nonfree/$pkgname/$tarball/$md5sum/$tarball". Assuming I'm not missing something obvious, I can think of three ways to deal with this:</div><div><br></div><div>a. Provide rfpkg-free and rfpkg-nonfree scripts, one for each namespace.</div><div><br></div><div>b. Attempt to download both and ignore failures (curl ... || true?), then check to see if the file exists before proceeding.</div><div><br></div><div>c. Somehow determine whether a package is in free/ or nonfree/ at runtime. This would be the optimal solution but I'm not sure if there's a good way to do it. Perhaps checking .git/config for a configured remote with URL containing "free" or "nonfree"?</div><div><br></div><div>Thoughts?</div><span><font color="#888888"><div><br></div><div>Ben Rosser</div></font></span></div></div></div>
</blockquote></div><br></div><div class="gmail_extra"><br></div></div></div><div class="gmail_extra">I ended up implementing (c) *and* (b); rfpkg-minimal attempts to read .git/config and then just tries to download from both if it is not there. I forked the fedpkg-minimal git repo and pushed to github here: <a href="https://github.com/TC01/rfpkg-minimal" target="_blank">https://github.com/TC01/rfpkg-minimal</a></div><div class="gmail_extra"><br></div><div class="gmail_extra">If this looks good, I'm happy to throw together a spec and submit a package for review.</div><span class=""><font color="#888888"><div class="gmail_extra"><br></div><div class="gmail_extra">Ben Rosser</div></font></span></div>
</blockquote></div><br></div><div class="gmail_extra">Well, preliminary review request opened, since I figured I might as well throw together a spec file too: <a href="https://bugzilla.rpmfusion.org/show_bug.cgi?id=4112">https://bugzilla.rpmfusion.org/show_bug.cgi?id=4112</a>. </div><div class="gmail_extra"><br></div><div class="gmail_extra">Ben Rosser</div></div>