<html>
<head>
<base href="http://bugzilla.rpmfusion.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Review Request: fdk-aac - Fraunhofer FDK AAC Codec Library"
href="http://bugzilla.rpmfusion.org/show_bug.cgi?id=2736#c28">Comment # 28</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Review Request: fdk-aac - Fraunhofer FDK AAC Codec Library"
href="http://bugzilla.rpmfusion.org/show_bug.cgi?id=2736">bug 2736</a>
from <span class="vcard"><a class="email" href="mailto:kwizart@gmail.com" title="Nicolas Chauvet <kwizart@gmail.com>"> <span class="fn">Nicolas Chauvet</span></a>
</span></b>
<pre>(In reply to Sérgio Basto from <a href="show_bug.cgi?id=2736#c26">comment #26</a>)
<span class="quote">> fedora-review --other-bz <a href="https://bugzilla.rpmfusion.org">https://bugzilla.rpmfusion.org</a> -b 2736 -m
> fedora-rawhide-x86_64-rpmfusion_nonfree
>
> no issues , just not sure is documentation aacDecoder.pdf and aacEncoder.pdf
> should be in devel package , at least in -doc sub package ... </span >
Theses files are developers documentation of the library, the packaging
guideline doesn't mandate from which size a sub-package should be made, but
since it's already in a -devel I think it's fine to have them in -devel. (it's
less than 1Mo)
<span class="quote">> fdk-aac.spec looks good , source field could be more simple :
> <a href="https://github.com/mstorsjo/%{name}/archive/%{commit0}/%{name">https://github.com/mstorsjo/%{name}/archive/%{commit0}/%{name</a>}-
> %{shortcommit0}.tar.gz</span >
Fixed this one locally along with using Source0 instead of Source:
Thx for the review.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>