<html>
<head>
<base href="http://bugzilla.rpmfusion.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rc040203@freenet.de" title="rc040203@freenet.de">rc040203@freenet.de</a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Review Request: vo-aacenc - VisualOn AAC encoder library"
href="http://bugzilla.rpmfusion.org/show_bug.cgi?id=1742">bug 1742</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>rc040203@freenet.de
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Review Request: vo-aacenc - VisualOn AAC encoder library"
href="http://bugzilla.rpmfusion.org/show_bug.cgi?id=1742#c22">Comment # 22</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Review Request: vo-aacenc - VisualOn AAC encoder library"
href="http://bugzilla.rpmfusion.org/show_bug.cgi?id=1742">bug 1742</a>
from <span class="vcard"><a class="email" href="mailto:rc040203@freenet.de" title="rc040203@freenet.de">rc040203@freenet.de</a>
</span></b>
<pre>(In reply to Hans de Goede from <a href="show_bug.cgi?id=1742#c21">comment #21</a>)
- MUSTFIX: Building is non-verbose
Please append --disable-silent-rules to %configure
- /usr/lib64/pkgconfig/vo-aacenc.pc seems broken to me.
It uses includedir=/usr/include, but the headers below /usr/include/vo-aacenc
are expecting to find vo-aacenc's headers under /usr/include/vo-aacenc:
e.g.
/usr/include/vo-aacenc/voAMRWB.h:#include "voAudio.h"
i.e. they expect -I/usr/include/vo-aacenc and not -I/usr/include.
- Consider to remove the "rm -rf %{buildroot}" from %install
It's not needed anymore unless you plan to build this package for really
ancient rhels.
- Consider to remove the "Group" tags. They aren't used for anything in Fedora.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>