<html>
<head>
<base href="http://bugzilla.rpmfusion.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Review Request: vo-aacenc - VisualOn AAC encoder library"
href="http://bugzilla.rpmfusion.org/show_bug.cgi?id=1742#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Review Request: vo-aacenc - VisualOn AAC encoder library"
href="http://bugzilla.rpmfusion.org/show_bug.cgi?id=1742">bug 1742</a>
from <span class="vcard"><a class="email" href="mailto:j.w.r.degoede@gmail.com" title="Hans de Goede <j.w.r.degoede@gmail.com>"> <span class="fn">Hans de Goede</span></a>
</span></b>
<pre>(In reply to rc040203 from <a href="show_bug.cgi?id=1742#c22">comment #22</a>)
<span class="quote">> (In reply to Hans de Goede from <a href="show_bug.cgi?id=1742#c21">comment #21</a>)
>
> - MUSTFIX: Building is non-verbose
> Please append --disable-silent-rules to %configure</span >
Fixed in 0.1.3-2
<span class="quote">> - /usr/lib64/pkgconfig/vo-aacenc.pc seems broken to me.
>
> It uses includedir=/usr/include,</span >
Right, vo-amrwbenc does the same thing, the users expect to need to do:
#include <vo-amrwbenc/enc_if.h>
I just tried building gstreamer1-plugins-bad-freeworld with vo-aacenc support
enabled and that works fine.
<span class="quote">> - Consider to remove the "rm -rf %{buildroot}" from %install
> It's not needed anymore unless you plan to build this package for really
> ancient rhels.</span >
Fixed in 0.1.3-2
<span class="quote">> - Consider to remove the "Group" tags. They aren't used for anything in
> Fedora.</span >
Fixed in 0.1.3-2
Here is 0.1.3-2 :
* Sat Sep 17 2016 Hans de Goede <<a href="mailto:j.w.r.degoede@gmail.com">j.w.r.degoede@gmail.com</a>> - 0.1.3-2
- Pass --disable-silent-rules to %%configure
- Drop obsolete Group tags, rm -rf %%{buildroot}
- Use %%make_install
<a href="http://jwrdegoede.danny.cz/vo-aacenc.spec">http://jwrdegoede.danny.cz/vo-aacenc.spec</a>
<a href="http://jwrdegoede.danny.cz/vo-aacenc-0.1.3-2.fc26.src.rpm">http://jwrdegoede.danny.cz/vo-aacenc-0.1.3-2.fc26.src.rpm</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>