<html>
<head>
<base href="http://bugzilla.rpmfusion.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:leigh123linux@gmail.com" title="leigh scott <leigh123linux@gmail.com>"> <span class="fn">leigh scott</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Review request: mp3fs - A dynamic MP encoding fuse file-system"
href="http://bugzilla.rpmfusion.org/show_bug.cgi?id=2444">bug 2444</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Blocks</td>
<td>
</td>
<td>3, 4
</td>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>rpmfusion-package-review@rpmfusion.org
</td>
<td>leigh123linux@gmail.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Review request: mp3fs - A dynamic MP encoding fuse file-system"
href="http://bugzilla.rpmfusion.org/show_bug.cgi?id=2444#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Review request: mp3fs - A dynamic MP encoding fuse file-system"
href="http://bugzilla.rpmfusion.org/show_bug.cgi?id=2444">bug 2444</a>
from <span class="vcard"><a class="email" href="mailto:leigh123linux@gmail.com" title="leigh scott <leigh123linux@gmail.com>"> <span class="fn">leigh scott</span></a>
</span></b>
<pre>Package Approved
Please fix the build flags when you import the package, change
%{make_build} LDFLAGS=-lm
to
%{make_build} LDFLAGS="$RPM_LD_FLAGS -lm" V=1
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Dist tag is present.
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc-c++
See: <a href="http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2">http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2</a>
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated", "GPL (v3 or
later) (with incorrect FSF address)". 20 files have unknown license.
Detailed output of licensecheck in
/home/leigh/2444-mp3fs/licensecheck.txt
The MIT detection is invailid as the file isn't used
MIT/X11 (BSD like)
------------------
mp3fs-0.91/config/install-sh
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[?]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mp3fs-
debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: mp3fs-0.91-2.fc26.x86_64.rpm
mp3fs-debuginfo-0.91-2.fc26.x86_64.rpm
mp3fs-0.91-2.fc26.src.rpm
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/coders.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/buffer.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/flac_decoder.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/fuseops.c
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/mp3_encoder.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/transcode.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/transcode.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/mp3fs.c
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/flac_decoder.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/buffer.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/coders.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/mp3_encoder.cc
3 packages and 0 specfiles checked; 12 errors, 0 warnings.
Rpmlint (debuginfo)
-------------------
Checking: mp3fs-debuginfo-0.91-2.fc26.x86_64.rpm
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/flac_decoder.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/fuseops.c
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/buffer.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/mp3_encoder.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/coders.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/coders.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/mp3fs.c
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/buffer.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/transcode.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/mp3_encoder.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/transcode.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/flac_decoder.cc
1 packages and 0 specfiles checked; 12 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/mp3_encoder.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/transcode.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/buffer.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/mp3_encoder.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/coders.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/mp3fs.c
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/fuseops.c
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/transcode.cc
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/coders.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/buffer.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/flac_decoder.h
mp3fs-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/mp3fs-0.91/src/flac_decoder.cc
2 packages and 0 specfiles checked; 12 errors, 0 warnings.
Requires
--------
mp3fs (rpmlib, GLIBC filtered):
fuse
libFLAC++.so.6()(64bit)
libFLAC.so.8()(64bit)
libc.so.6()(64bit)
libfuse.so.2()(64bit)
libfuse.so.2(FUSE_2.5)(64bit)
libfuse.so.2(FUSE_2.6)(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libid3tag.so.0()(64bit)
libm.so.6()(64bit)
libmp3lame.so.0()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
rtld(GNU_HASH)
mp3fs-debuginfo (rpmlib, GLIBC filtered):
Provides
--------
mp3fs:
mp3encoder
mp3fs
mp3fs(x86-64)
mp3fs-debuginfo:
mp3fs-debuginfo
mp3fs-debuginfo(x86-64)
Source checksums
----------------
<a href="https://github.com/khenriks/mp3fs/releases/download/v0.91/mp3fs-0.91.tar.gz">https://github.com/khenriks/mp3fs/releases/download/v0.91/mp3fs-0.91.tar.gz</a> :
CHECKSUM(SHA256) this package :
a47b5e351b7660e6f535a3c5b489c5a8191209957f8c0b8d066a5c221e8ecf92
CHECKSUM(SHA256) upstream package :
a47b5e351b7660e6f535a3c5b489c5a8191209957f8c0b8d066a5c221e8ecf92
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64-rpmfusion_free
--other-bz <a href="https://bugzilla.rpmfusion.org">https://bugzilla.rpmfusion.org</a> -b 2444
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>