<html>
<head>
<base href="https://bugzilla.rpmfusion.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Review Request: HandBrake - An open-source multiplatform video transcoder"
href="https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Review Request: HandBrake - An open-source multiplatform video transcoder"
href="https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361">bug 4361</a>
from <span class="vcard"><a class="email" href="mailto:kwizart@gmail.com" title="Nicolas Chauvet <kwizart@gmail.com>"> <span class="fn">Nicolas Chauvet</span></a>
</span></b>
<pre>Few comments:
- Does it really uses the bundled fdk-aac instead of the internal ffmpeg aac
encoder ?
# Use system libraries in place of bundled ones
for module in a52dec %{?_with_fdk:fdk-aac}
...
- We cannot rely on this currently (we might need to restart the discussion)
At least it should be dlopenable.
Requires: libdvdcss%{_isa}
- What is the point to have -gui -tui separation without any main package ?
I would use handbrake (main) as the default (-gui) package and use -core or
keep -tui as a sub-package.
(even using a virtual provide for lower case handbrake compatibility if not
handled by dnf already).
- Using , %make_build, %make_install, missing BR gcc, gcc-c++
- Remove dependency that are in the default BR (m4, patch, Makefile, etc)
- No appdata ?
Thx for this submit.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>