[Bug 151] Review Request: systemc - Design and verification language for Hardware

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=151





--- Comment #5 from Chitlesh GOORAH <cgoorah at yahoo.com.au>  2008-11-29 21:30:28 ---
(In reply to comment #4)
> This package needs some work. rpmlint gives some ~300 warnings/errors. The main
> reasons seems to be your unusual prefix for configure.

No the main reason is the devel-file-in-non-devel-package. Thus the above
mentioned 300 reflects the number of files and not the amount of work the
package requires.

> -Why don't you use %{_usr} for prefix? Or just use %configure and it will take
> care of it for you.

In this context, please do not confuse prefix with exec_prefix
Here prefix is used as an install base location

It is not wise to opt another install base location as:
- it will conflict with the whole set of fedora/rpmfusion packages


> -I see you defining the $DESTDIR. But there is no reference to the $DESTDIR
> anywhere in the Makefiles or the code.

Removed

> -The contents of the include directory must go to a devel subpackage.

systemc is meant to be used at low-level. systemc is used to design hardware,
and just requires the includes/

> -The library is built static. Is there no way of making it dynamic?

No, it was not designed to.

> -There are a lot of "wrong EOL encoding" warnings. You can use 
>    sed 's/\r//' filename
> to fix those. But make sure you preserve timestamps for the relevant files.

done

> -There are bunch of binary files in the source tarball. For instance, the
> .DS_Store files. You should remove all of them during %prep


done 

> -We don't mention the %buildroot during %prep. That comes in the %build and
> %install sections.
> 

unfortunately in this case, yes.

Updated
Spec URL: http://chitlesh.fedorapeople.org/systemC/systemc.spec
SRPM URL: http://chitlesh.fedorapeople.org/systemC/systemc-2.2.0-3.fc10.src.rpm


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.