[Bug 303] Review request: Mupen64Plus - A Nintendo64 Emulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303





--- Comment #16 from Juan Moreno <uncholowapo at gmail.com>  2009-02-18 01:30:17 ---
(In reply to comment #15)
> (In reply to comment #14)
> > I have been trying to get a sponsor with no luck. I will keep trying though.
> 
> Update this package (and any other package you have under review) with the
> suggested changes.
> 
> "Unofficially" review other packages so that possible sponsors can evaluate
> your knowledge.
> 
> Other info here:
> https://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
> 

OK well this is what I have so far. rpmlint shows no errors of the SRPM and
.spec file:

[Juan at linux64 ~]$ rpmlint -i rpmbuild/SRPMS/Mupen64Plus-1.5-1.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[Juan at linux64 ~]$ rpmlint -i rpmbuild/SPECS/Mupen64Plus.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

There is one little problem though; In the .desktop file it specifies an icon
directory that does not exist,
/usr/local/share/mupen64plus/icons/mupen64plus-large.png, and I need it to
point to /usr/share/mupen64plus/icons/mupen64plus-large.png. It still appears
in my Games menu without the icon beside it. Can I do this with an option in
desktop-file-install or do I have to create a totally new .desktop file from
scratch?

The install directories are a bit messy too but it still compiles and runs
fine.


Name:           Mupen64Plus
Version:        1.5
Release:        1%{?dist}
Summary:        A Nintendo 64 Emulator
Group:          Applications/Emulators
License:        GPLv2+
URL:            http://code.google.com/p/mupen64plus
Source0:       http://mupen64plus.googlecode.com/files/%{name}-1-5-src.tar.gz 
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires:  gtk2-devel
BuildRequires:  SDL-devel
BuildRequires:  SDL_ttf-devel
BuildRequires:  libpng-devel
BuildRequires:  freetype-devel
BuildRequires:  zlib-devel
BuildRequires:  desktop-file-utils
Requires:       hicolor-icon-theme
Requires:       SDL
Requires:       SDL_ttf
Requires:       libpng
Requires:       freetype
Requires:       zlib

%description
Mupen64Plus is a plugin-based N64 emulator for Linux which is capable of 
accurately playing many games. Included are four MIPS R4300 CPU emulators, 
with dynamic recompilers for 32-bit x86 and 64-bit amd64 systems, and 
necessary plugins for audio, graphical rendering (RDP), signal co-processor 
(RSP), and input. There are 3 OpenGL video plugins included: glN64, 
RiceVideoLinux, and Glide64.

%prep
%setup -q -n %{name}-1-5-src


%build
CFLAGS="%{optflags}"
export CFLAGS
CXXFLAGS="$CFLAGS"
export CXXFLAGS
%{__make} all %{_smp_mflags}


%install
%{__rm} -rf %{buildroot}
%{__make} install PREFIX=%{buildroot}%{_prefix}
SHAREDIR=%{buildroot}%{_datadir}/mupen64plus BINDIR=%{buildroot}%{_bindir}
LIBDIR=%{buildroot}%{_datadir}/mupen64plus/plugins
MANDIR=%{buildroot}%{_mandir}/man1

desktop-file-install --vendor="" \
 --dir=%{buildroot}%{_datadir}/applications \
 %{buildroot}%{_datadir}/applications/mupen64plus.desktop




%clean
%{__rm} -rf %{buildroot}


%files
%defattr(-,root,root,-)
%doc LICENSES README RELEASE TODO
%{_bindir}/mupen64plus
%{_datadir}/mupen64plus
%{_datadir}/applications/mupen64plus.desktop
%{_mandir}/man1/mupen64plus.1.gz


%changelog
* Sun Jan 4 2009 Juan Moreno <uncholowapo at gmail.com> 1.5
- New release after half a year. Read changelog for details

* Fri Jan 2 2009 Juan Moreno <uncholowapo at gmail.com> 1.4.1
- Initial build


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.