[Bug 303] Review request: Mupen64Plus - A Nintendo64 Emulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303





--- Comment #17 from Andrea Musuruane <musuruan at gmail.com>  2009-02-18 14:07:16 ---
(In reply to comment #16)

You should not post SPEC file in a bugzilla entry but you must provide two link
one to the spec file and one to the src.rpm. These files must be hosted
somewhere on the net. I cannot believe you cannot find a free hosting server.

> OK well this is what I have so far. rpmlint shows no errors of the SRPM and
> .spec file:
> 
> [Juan at linux64 ~]$ rpmlint -i rpmbuild/SRPMS/Mupen64Plus-1.5-1.fc10.src.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> [Juan at linux64 ~]$ rpmlint -i rpmbuild/SPECS/Mupen64Plus.spec
> 0 packages and 1 specfiles checked; 0 errors, 0 warnings.

* You also need to validate with rpmlint all *.rpm files created with the build
process. 

After that you have to install all *.rpm files created with the build process
and use rpmlint against the installed files. For example:

rpmlint Mupen64Plus

> There is one little problem though; In the .desktop file it specifies an icon
> directory that does not exist,
> /usr/local/share/mupen64plus/icons/mupen64plus-large.png, and I need it to
> point to /usr/share/mupen64plus/icons/mupen64plus-large.png. It still appears
> in my Games menu without the icon beside it. Can I do this with an option in
> desktop-file-install or do I have to create a totally new .desktop file from
> scratch?

* You must report this problem upstream. 

Then, while waiting for upstream to fix it, you can use grep to fix the Icon
entry in the desktop file. I suggest you not to use an absolute path.

You also have to install the icons in the appropriate directories.

http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html

* It seems strange to me that rpmlint does not complain about the missing
release in the changelog entries:

* Sun Jan 4 2009 Juan Moreno <uncholowapo at gmail.com> 1.5
- New release after half a year. Read changelog for details

* Moreover, you must write the changes in the changelog entries. The above one
is not acceptable.

* Categories in the desktop file must be changed from 

Categories=Qt;Game;

to

Categories=Game;Emulator;

use --add-category and --remove-category options in desktop-file-install. For
more info, read its man page.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.