[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3965

Vasiliy Glazov <vascom2 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vascom2 at gmail.com

--- Comment #11 from Vasiliy Glazov <vascom2 at gmail.com> 2016-08-22 10:15:16 CEST ---
1. hicolor-icon-theme must be in Requires: but not in BuildRequires:.

2. Correct QMAKE_LFLAGS as in %{qmake_qt5}.

3. Use %make_build instead of make %{?_smp_mflags}.

4. Remove validating desktop-file from %check section because you already use
desktop-file-install 
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.