[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3965

--- Comment #12 from MartinKG <mgansser at alice.de> 2016-08-22 21:02:20 CEST ---
(In reply to comment #11)
> 1. hicolor-icon-theme must be in Requires: but not in BuildRequires:.
> 
> 2. Correct QMAKE_LFLAGS as in %{qmake_qt5}.
> 
> 3. Use %make_build instead of make %{?_smp_mflags}.
> 
> 4. Remove validating desktop-file from %check section because you already use
> desktop-file-install 
> https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

new rpms files:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/miam-player.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/miam-player-0.8.1-0.2git193ab01.fc24.src.rpm

%changelog
* Mon Aug 22 2016 Martin Gansser <martinkg at fedoraproject.org> -
0.8.1-0.2git193ab01
- Removed BR hicolor-icon-theme
- Added Requires hicolor-icon-theme
- Added %%{optflags} to QMAKE_LFLAGS
- Use %%make_build instead of make %%{?_smp_mflags}
- Remove validating desktop-file from %%check section because
desktop-file-install
  is already used

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.