[Bug 126] Review Request: dvdrip - Graphical DVD ripping and encoding tool

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126





--- Comment #18 from NicolasChauvet <kwizart at gmail.com>  2008-12-10 13:10:40 ---
(In reply to comment #17)
> I worked on this package a little more. Here's what I made:
I will re-use this, Thx for the improvements.

> > * What is wrong with the parallel make? I'm asking for both C side and perl
> > side.
The warning message have disappeared (jobserver unavailable) so I have
re-introduced it. But it fails again at locale generation (randomly on my
dualcore), so this isn't tread safe.

> > * These BR's seem unnecessary:
> >      BuildRequires: perl(ExtUtils::MakeMaker)
> >      BuildRequires: perl(Gtk2) >= 1.081
> >      BuildRequires: perl(Locale::TextDomain) >= 1.16
> > The first two are pulled up by other ones. 
if not added I will have:
-----------
Warning: prerequisite AnyEvent 1.02 not found.
Warning: prerequisite Event 1.06 not found.
Warning: prerequisite Event::ExecFlow 0.62 not found.
Warning: prerequisite Event::RPC 0.89 not found.
Warning: prerequisite Gtk2 1.121 not found.
Warning: prerequisite Gtk2::Ex::FormFactory 0.65 not found.
Warning: prerequisite Locale::TextDomain 1.16 not found.
-------------
and:
----------
Checking if your kit is complete...
Warning: the following files are missing in your kit:
        perl-modules/AnyEvent-1.02.tar.gz
        perl-modules/Event-ExecFlow-0.63.tar.gz
        perl-modules/Event-RPC-0.90.tar.gz
        perl-modules/Gtk2-Ex-FormFactory-0.65.tar.gz
Please inform the author.
----------
If I add the needed Dependencies, I only have the second message.

I want to keep all mentioned dependencies as notified in the Makefile.PL (no
matters of if they are already bring by another one) since it can allow to
control the correct version at build time for each of them.
(will be particularly needed for the EL-5 package, but also on update).

Changelog
- Update BuildRequirement as described in Makefile.PL
- Fix Make test

SRPM:
http://rpms.kwizart.net/fedora/reviews/dvdrip/dvdrip-0.98.9-5.fc11.src.rpm
SPEC:
http://rpms.kwizart.net/fedora/reviews/dvdrip/dvdrip.spec


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.