[Bug 26] Review request: dvbcut - Clip and convert DVB transport streams to MPEG2 program streams

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=26





--- Comment #34 from David Timms <dtimms at iinet.net.au>  2008-12-31 06:32:27 ---
(In reply to comment #33)
> Changelog:
> - removed ugly configure hack in %%install
>     A much needed improvement. You must report upstream that there is no clean
> way to specify a DESTDIR.
> 
> - removed %%{?_smp_mflags} from make invocation
>     It was because of smp_flags that the rpmbuild process didn't run the
> setversion.sh script.
Is that really a problem with the autoconf/configure/make ?

> - patched configure to fix qt lib dir
>     I think it is much cleaner with sed. This patch must be reported upstream.

Would those two patches be OK for upstream to use ? Will it stop it building in
to /usr/local by default it ? (I'm just a bit of a hacker when it comes to this
building stuff).

> - cosmetic changes
Yes, I could see that splitting up requires into separate lines could make it
easier to check they are correct, and make for simpler future patches.
With the split lines in make, configure, same response, except that indenting
by the same amount as a if/looping structure to me suggests that those lines
are some how conditional, so I will add an extra indent for those lines.

Builds on x86_64 and i386.
rpmlint clean for x86_64 and i386.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.