[Bug 26] Review request: dvbcut - Clip and convert DVB transport streams to MPEG2 program streams

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=26





--- Comment #35 from Andrea Musuruane <musuruan at gmail.com>  2008-12-31 11:47:47 ---
(In reply to comment #34)
> > - removed %%{?_smp_mflags} from make invocation
> >     It was because of smp_flags that the rpmbuild process didn't run the
> > setversion.sh script.
> Is that really a problem with the autoconf/configure/make ?

Well, no. Some makefiles are not meant to be run in parallel. Dvbcut makefile
is one of those. That's why I removed the %%{?_smp_mflags} macro from make
invocation.

> > - patched configure to fix qt lib dir
> >     I think it is much cleaner with sed. This patch must be reported upstream.
> 
> Would those two patches be OK for upstream to use ? Will it stop it building in
> to /usr/local by default it ? (I'm just a bit of a hacker when it comes to this
> building stuff).

sed -i 's,-L$QTDIR/$mr_libdirname,-L$QTDIR/lib,' configure.in

This just specifies that qt libraries are always under lib subdirectory in
$QTDIR. The name of the directory doesn't change depending on arch, only $QTDIR
changes depending on arch. As long as other distributions do the same, this is
fine.

What I wanted to tell you is that the problems found during this review must be
reported upstream.

If you provide an updated package with your latest changes, I'll review it.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.