[Bug 67] Review Request: open-vm-tools - VMware Guest OS Tools

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67


Orcan Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |orcanbahri at yahoo.com




--- Comment #4 from Orcan Ogetbil <orcanbahri at yahoo.com>  2008-10-22 21:14:39 ---
The package needs some more work. Here are my notes:

* rpmlint errors/warnings:

open-vm-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line
51)
open-vm-tools.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/libguestlib.so
open-vm-tools.x86_64: W: spurious-executable-perm
/usr/share/doc/open-vm-tools-0.0.0.123053/README
open-vm-tools.x86_64: E: wrong-script-end-of-line-encoding
/usr/share/doc/open-vm-tools-0.0.0.123053/README
open-vm-tools.x86_64: W: spurious-executable-perm
/usr/share/doc/open-vm-tools-0.0.0.123053/ChangeLog
open-vm-tools.x86_64: E: executable-marked-as-config-file
/etc/vmware-tools/vm-support
open-vm-tools.x86_64: W: spurious-executable-perm
/usr/share/doc/open-vm-tools-0.0.0.123053/AUTHORS
open-vm-tools.x86_64: E: script-without-shebang /etc/pam.d/vmware-guestd-x64
open-vm-tools.x86_64: E: executable-marked-as-config-file
/etc/vmware-tools/poweron-vm-default
open-vm-tools.x86_64: E: setuid-binary /usr/bin/vmware-user-suid-wrapper root
04755
open-vm-tools.x86_64: E: non-standard-executable-perm
/usr/bin/vmware-user-suid-wrapper 04755
open-vm-tools.x86_64: E: setuid-binary /sbin/mount.vmhgfs root 04755
open-vm-tools.x86_64: E: non-standard-executable-perm /sbin/mount.vmhgfs 04755
open-vm-tools.x86_64: W: devel-file-in-non-devel-package
/usr/include/vmci/vmci_sockets.h
open-vm-tools.x86_64: E: executable-marked-as-config-file
/etc/vmware-tools/poweroff-vm-default
open-vm-tools.x86_64: E: postin-without-ldconfig
/usr/lib64/libguestlib.so.0.0.0
open-vm-tools.x86_64: E: postun-without-ldconfig
/usr/lib64/libguestlib.so.0.0.0
open-vm-tools.x86_64: W: spurious-executable-perm
/usr/share/doc/open-vm-tools-0.0.0.123053/NEWS
open-vm-tools.x86_64: W: spurious-executable-perm
/usr/share/doc/open-vm-tools-0.0.0.123053/COPYING
open-vm-tools.x86_64: E: executable-marked-as-config-file
/etc/vmware-tools/resume-vm-default
open-vm-tools.x86_64: W: non-conffile-in-etc /etc/modprobe.d/vmnics
open-vm-tools.x86_64: W: non-conffile-in-etc /etc/sysconfig/mouse
open-vm-tools.x86_64: E: executable-marked-as-config-file
/etc/vmware-tools/suspend-vm-default
open-vm-tools.x86_64: W: obsolete-not-provided open-vm-tools-kmod
open-vm-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/vmware-toolbox-cmd ['/usr/lib64']
open-vm-tools.x86_64: E: use-tmp-in-%post
open-vm-tools.x86_64: W: service-default-enabled /etc/init.d/vmware-guest
open-vm-tools.x86_64: E: incoherent-subsys /etc/init.d/vmware-guest
vmware-guestd
open-vm-tools.x86_64: W: no-reload-entry /etc/init.d/vmware-guest
open-vm-tools.x86_64: W: incoherent-init-script-name vmware-guest
open-vm-tools.x86_64: E: invalid-desktopfile
/usr/share/applications/vmware-toolbox.desktop

Most of these errors/warnings can be fixed easily. For instance, do a
   rpmlint -I spurious-executable-perm
to learn more about the error/warning message. You will need to come up with a
acceptable reasoning if you need any of the sources of these messages stay as
they are. Feel free to ask questions if you're not sure how to solve a specific
issue.

* I think you should take the "+" off from the License field since the files
you are compiling include the explicit phrase:
   * This program is free software; you can redistribute it and/or modify it
   * under the terms of the GNU Lesser General Public License as published
   * by the Free Software Foundation version 2.1 and no later version.

* Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.

* Is this permission really needed?
   %attr(4755,root,root) %{_bindir}/vmware-user-suid-wrapper
Won't it go with %defattr ?

* Header files must be in a -devel package.

* If a package contains library files with a suffix (e.g. libfoo.so.1.1), then
library files that end in .so (without suffix) must go in a -devel package. In
the vast majority of cases, devel packages must require the base package using
a fully versioned dependency: Requires: %{name} = %{version}-%{release}

* Please follow the Desktop Files guidelines of Fedora:
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
You need to make use of desktop-file-install and/or desktop-file-validate

* Make sure you that the setuid of the mount file won't generate security
issues as pointed out by Thorsten.

* After you're done with all of the above please verify that the final provides
and requires are sane  and that the package installs and removes properly (I
didn't check this yet, will do it after everything is done).


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.