[Bug 285] Review Request: VirtualBox-OSE - A general-purpose full virtualizer for PC hardware

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=285





--- Comment #18 from Xavier Lamien <lxtnow at gmail.com>  2009-04-06 00:15:15 ---
hmm... I've got a couple of error which need fixes.

VirtualBox-OSE-2.1.4-2.fc11.i586 :
------------------------------------
36 unstripped-binary-or-object (easy fix)
26 rpath issues (you'll need to check kbuild files)
03 setuid on binaries (easy fix)


VirtualBox-OSE-devel-2.1.4-2.fc11.i586 :
-----------------------------------------
17 executable scripts issues (easy fix)


VirtualBox-OSE-guest-2.1.4-2.fc11.i586 :
-----------------------------------------
04 unstripped binary (easy fix)
02 executable files in modules sub-dir /etc/sysconfig/modules


Package tree and dependencies :
------------------------------------
Currently -guest and main packages provide the same virtual (-kmod-common's)
which's harmless at first sight but, imply to install main package even on the
guest system.
As kmod package requires -kmod-common, that's sound fair enough as kmod package
is shipped with both main vboxdrv and Guest drivers.
The current state is when trying to install -guest, it's looking for kmod
package which's looking for -kmod-common which pull down main package and
-guest's.
Also note that udev's rule (kmod common file) which's required by vboxdrv is
shipped by main package.

Actually, the easiest way to avoid a such thing is to build a
kmod-VirtualBox-OSE and kmod-VirtualBox-OSE-GuestAddition packages.
That will also avoid to install vboxdrv on guest which is useless.

We could also remove virtual on -kmod-common and build them for real
by setting up something like this,

VirtualBox-OSE-kmod-common providing :
%config %{_sysconfdir}/udev/rules.d/90-vboxdrv.rules
%config %{_sysconfdir}/sysconfig/modules/%{name}.modules

VirtualBox-OSE-GuestAddition-kmod-common providing :
%config %{_sysconfdir}/sysconfig/modules/%{name}-guest.modules

kmod-VirtualBox-OSE providing :
vboxdrv

kmod-VirtualBox-OSE-GuestAddition :
vboxnetflt
vboxadd
vboxvfs


NVR issues :
----------------------
Provides and requires against main or sub packages tree have to be set as
follow to avoid brake package dependencies :
$package_name = %{version}-%{release} 


Naming issue :
---------------------
I'd prefer you keep the current complete name of guest addition
to match with upstream.


Package conflict issue :
----------------------------
We need to prevent conflict against VirtualBox closed-source packages
Adding some conflicts should be good enough.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.