[Bug 285] Review Request: VirtualBox-OSE - A general-purpose full virtualizer for PC hardware

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=285





--- Comment #19 from Lubomir Rintel <lkundrak at v3.sk>  2009-04-06 00:35:48 ---
(In reply to comment #18)
> hmm... I've got a couple of error which need fixes.
> 
> VirtualBox-OSE-2.1.4-2.fc11.i586 :
> ------------------------------------
> 36 unstripped-binary-or-object (easy fix)

I won't call this easy fix. We need to select what to strip and what not. I
don't see a nice way to prevent find-debuginfo from stripping what it shouldn't
other than chmod -x -ing it and then set it back to executable via %attr, which
is not particularly elegant. Do you insist on this?

> 26 rpath issues (you'll need to check kbuild files)

I was under impression rpaths are used here (and we are not having only the
standard rpaths), but I'll check and see what can be done.

> 03 setuid on binaries (easy fix)

This was upstream decision and I'd be careful to change that. On the other
hand, having the beast completely setuid really doesn't sound much sane to me.
What would you do with that? Use consolehelper? (well, you see, PolicyKit is
probably not going to happen ;)

> VirtualBox-OSE-devel-2.1.4-2.fc11.i586 :
> -----------------------------------------
> 17 executable scripts issues (easy fix)

Will take a look.

> VirtualBox-OSE-guest-2.1.4-2.fc11.i586 :
> -----------------------------------------
> 04 unstripped binary (easy fix)

See above.

> 02 executable files in modules sub-dir /etc/sysconfig/modules

This makes sense to be executable, no?

> Package tree and dependencies :
> ------------------------------------
> Currently -guest and main packages provide the same virtual (-kmod-common's)
> which's harmless at first sight but, imply to install main package even on the
> guest system.
> As kmod package requires -kmod-common, that's sound fair enough as kmod package
> is shipped with both main vboxdrv and Guest drivers.
> The current state is when trying to install -guest, it's looking for kmod
> package which's looking for -kmod-common which pull down main package and
> -guest's.

This sounds like a yum (a bug?) glitch to me. I would not expect such behavior,
will need to check.

> Also note that udev's rule (kmod common file) which's required by vboxdrv is
> shipped by main package.

And only main package makes use of vboxdrv. Makes sense to me.

> Actually, the easiest way to avoid a such thing is to build a
> kmod-VirtualBox-OSE and kmod-VirtualBox-OSE-GuestAddition packages.
> That will also avoid to install vboxdrv on guest which is useless.

Sounds like too much overhead to me and I'd prefer to avoid as much as I can.

> We could also remove virtual on -kmod-common and build them for real
> by setting up something like this,
> 
> VirtualBox-OSE-kmod-common providing :
> %config %{_sysconfdir}/udev/rules.d/90-vboxdrv.rules
> %config %{_sysconfdir}/sysconfig/modules/%{name}.modules
> 
> VirtualBox-OSE-GuestAddition-kmod-common providing :
> %config %{_sysconfdir}/sysconfig/modules/%{name}-guest.modules
> 
> kmod-VirtualBox-OSE providing :
> vboxdrv
> 
> kmod-VirtualBox-OSE-GuestAddition :
> vboxnetflt
> vboxadd
> vboxvfs

I'd vehemently protest splitting it up even more. Will have to figure the
-common dependency issue though.

> NVR issues :
> ----------------------
> Provides and requires against main or sub packages tree have to be set as
> follow to avoid brake package dependencies :
> $package_name = %{version}-%{release} 

Will fix.

> Naming issue :
> ---------------------
> I'd prefer you keep the current complete name of guest addition
> to match with upstream.

Which is ...?

> Package conflict issue :
> ----------------------------
> We need to prevent conflict against VirtualBox closed-source packages
> Adding some conflicts should be good enough.

We're not shipping VirtualBox closed source in RPMFusion. I'd say file
conflicts are enough here (and we indeed do have those).

Much thanks for the review so far, I'll work on new packages and post them here
in a couple of days.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.