[Bug 459] Review request: nvidia-cuda-toolkit - NVIDIA CUDA Toolkit libraries

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=459





--- Comment #5 from Milos Jakubicek <xjakub at fi.muni.cz>  2009-04-13 01:59:14 ---
Sorry for the delay,

(In reply to comment #4)
> You have packaged cuda like if it was a library, but it is a more a compiler
> than a library. I don't think using a -devel will make sense.

Yes, I was unsure about this, I've removed the -devel subpackage now.

> Usually, Fedora guideline are pretty clear on the name of the package, it need
> to be the name of the "source tarball". In this case, it should be cudatoolkit.
> I would agree to use only cuda (which is the kown product name), but having the
> package named cudatoolkit and eventually provides cuda seems the prefered way.
> I'm aware that historically, the package name has changed. (and may change with
> newer version also).

Done, although I'd note that the general rule is "tarball name OR project
name".

> - Does the package need to be (can be) multilib compliant or multiarch
> compliant. At this time it is neither mutlilibs nor multiarches compliant.
> (it may not be relevant)

I've split the libraries into a -libs subpackage, so this is now multilib.
Multiarch doesn't make sense IMO.

> - There is also a cuda-sdk (cuda-devel ?)
> http://www.nvidia.com/object/thankyou_linux.html?url=/compute/cuda/2_1/SDK/cuda-sdk-linux-2.10.1215.2015-3233425.run
> Is it needed along with cuda ?

No, it isn't, it contains mostly code samples. I do not find it worth packaging
now.

> * - Development/Languages seems more accurate to describe the rpm Group.

Done

> * - Does Cg is needed (bundled within) for this package ? 
>   And which version it might work best with ?

Where do you see it bundled? Maybe I just misunderstood the question...

> * - The package are binary only, but nvidia currently only certify it on F-9
> and EL-5. Also with the rpm strongerHash feature, rpm built on F-10 and beyond
> could not be compatible with older distro. Thus I think the disttag must be
> re-enabled.

Of course, just didn't notice it is missing. Added, thanks.
> 
> * For the debuginfo, You can have a look on the rar review at rpmfusion to see
> how debuginfo can be disabled without touching binaries, or with
> xorg-x11-drv-nvidia\* to override the build id while extracting debuginfo.
>

Thanks for hint, used the method from xorg...nvidia.

> * please use %{version} for the Source0/1.

Done.

> * Please use install with -p whenever it is possible to prevent timestamp
> change. (for example, when installing the initscript or when you convert the
> doc in utf8). That will avoid.

Done, converting has been already done by touch -r.

> * scriplets need to end with || : to avoid rpm transaction to be canceled if
> something went wrong for any reason. (i don't know why an initscript would be
> needed - will check later)
> 

Fixed, there were also others like "mv" which must be appended with ||: so as
not to fail on 32bit (moving into same dir).

See the new SPEC file and SRPM in
http://mjakubicek.fedorapeople.org/nvidia-cuda-toolkit/


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.