[Bug 447] Review Request: ffmpeg2dirac - Convert any file that ffmpeg can decode to dirac or theora

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=447


Orcan Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2                           |3
             Status|NEW                         |ASSIGNED




--- Comment #5 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-04-13 07:26:01 ---
I reviewed this. I have 2 cosmetics suggestions and there are 3 blockers:

! Please make the description span evenly, to 80 columns. It'll look nicer.

! You can pass mandir=PREFIX/share/man to "scons install" line to save yourself
from the trouble

* Parallel make must be supported whenever possible. If it is not supported,
this should be noted in the SPEC file as a comment.

* Compiler flags must be appropriate. The Fedora specific flags are not passed
during the linking phase. Afaik, at least -g -Wall needs to be passed.

* More importantly, during "scons install" the code gets rebuilt, which is bad.
Moreover, this time it gets built without optflags at all, even during the
compilation.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.