[Bug 985] Review request: ProjectX-0.90.4.00-2

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=985





--- Comment #22 from Göran Uddeborg <goeran at uddeborg.se>  2010-08-08 14:03:34 ---
Here comes the next version.

- A version number is added to the sysjava patch.

- The snapshot script excludes the lib directory and a few other files
irrelevant for Fedora when creating the archive.

- The archive was some 15% smaller with xz compression, so I switched to that.

- The desktop file modification is put in a separate patch file.

- The jar dependencies are not discovered automatically, so they are still in
the spec file.

- The warnings you saw were signs of a mistake of mine.  Different Java
compilers gives different warnings.  I didn't see them in my regular
environment, where I have Java 1.6.0 installed.  The only warnings I saw were a
couple about using a deprecated API.  (The authors mention those in the ReadMe
file, so they are already aware.)  But the build requirements in the SPEC file
only said Java 1.2.2 was needed, which is what the source documentation says is
the minimum.  And when creating a minimal environment, the java compiler from
GCJ met that requirement.  With that compiler, you get all the warnings.

I'm not sure how best to handle this.  For now I've added requirements on Java
1.6.0 or later.  I looked at the spec files of a couple of other, randomly
choosen, Java packages, and they had that.  But it wasn't immediately clear if
that was an actual requirement of the Java source in those packages, or if it
was the same situation as mine.  Some further input from some more experienced
Java packager on how to handle GCJ, if GCJ is to be supported at all, would be
appreciated.  If it simplifies things if I only build for F13 or later, or only
F14 or later, I would do that.

- The -fvar-tracking-assignment message is still there.  But it is only a
"note", so I assume it's not important.  I don't really know, though.

- There are also some warnings when it tries to create the debuginfo package,
which seems to be about temporary files created by the GCJ AOT compiler but not
kept.  I have ignored those too, assuming that there is nothing to do about it,
but again, I don't really know.

- Finally, the failure to show the help was a bit harder.  ProjectX is
apparently designed to run where it was built, not to be installed.  So it
looks for "htmls/index.html" locally from where it is started.  The string
"htmls" is in one place in the code, but the addition of the current directory
is done elsewhere, and the latter place is reached by several paths.  So there
was no immediately obvious quick fix.

Reading the code and digging a bit in my memory about Java, I finally figured
out that if I put the html pages inside the jar file rather than in the file
system, the code will find them.  So I've added a third patch, modifying the
build script to do this.

- As for the application bugs, are you sure the first one really is a bug?  If
I select a subdirectory and click "open", the directory list is updated.  From
what I understand, that could be how the dialog is supposed to work.

The second I don't quite understand.  Where is the "sort view button"?

Updated version available at:
ftp://ftp.uddeborg.se/pub/ProjectX/ProjectX.spec
ftp://ftp.uddeborg.se/pub/ProjectX/ProjectX-0.90.4.00-6.20100806cvs.fc14.src.rpm


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.