[Bug 985] Review request: ProjectX-0.90.4.00-2

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=985





--- Comment #23 from David Timms <dtimms at iinet.net.au>  2010-08-08 16:17:08 ---
(In reply to comment #22)
> - A version number is added to the sysjava patch.
Ack.

> - The snapshot script excludes the lib directory and a few other files
> irrelevant for Fedora when creating the archive.
Ack.

> - The archive was some 15% smaller with xz compression, so I switched to that.
And most people will have xz since rpms uses it, so good pickup.

> - The desktop file modification is put in a separate patch file.
As I understand it, desktop-file-install validates the .desktop and adds the
version number. Hence we shouldn't add:
+Version=1.0

> - Finally, the failure to show the help was a bit harder.  ProjectX is
... 
> Reading the code and digging a bit in my memory about Java, I finally figured
> out that if I put the html pages inside the jar file rather than in the file
> system, the code will find them.  So I've added a third patch, modifying the
> build script to do this.
Ack.

=====
> - As for the application bugs
Actually, we aren't explicitly required to fix bugs, however, the following is
reasonable bad.

> The second I don't quite understand.  Where is the "sort view button"?
File|Add
change a few directories, use the up directory icon near top-right.
Also click the top-right "show detail" list icon. (I called that the wrong
name, but it has no hint).

Things get really weird, eg. disk has /home/1/2/3/4/5 the path shown in the top
dropdown is 3, but the dialog is showing the contents of the folder 5.
=====
Given both our lack of java rpm packaging experience, perhaps you could ask on
either a fedora java or jpackage list about whether the spec is clear, follows
guildelines, and is there anything else that should be added/changed ?


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.