[Bug 2298] Review request: fceux - A cross platform, NTSC and PAL Famicom/NES emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2298

--- Comment #2 from Jeremy Newton <alexjnewt at hotmail.com> 2012-04-27 17:46:17 CEST ---
Package review:

+: OK
-: must be fixed
=: should be fixed (at your discretion)
?: Question or clairification needed
N: not applicable

MUST:
[+] rpmlint output
200 someodd errors from incorrect-fsf-address, though this has been addressed
upstream, so no problems.
[+] follows package naming guidelines
[+] spec file base name matches package name
[+] package meets the packaging guidelines
[+] package uses a Fedora approved license:
[-] license field matches the actual license.
The follow files were not picked up as GPLv2+ in licensecheck:
fceu2.1.5/src/emufile.cpp: MIT/X11 (BSD like)
fceu2.1.5/src/emufile.h: MIT/X11 (BSD like)
fceu2.1.5/src/drivers/common/hq3x.cpp: LGPL (v2.1 or later)
fceu2.1.5/src/drivers/common/nes_ntsc_impl.h: LGPL (v2.1 or later) 
fceu2.1.5/src/drivers/common/nes_ntsc.c: LGPL (v2.1 or later) 
fceu2.1.5/src/drivers/common/hq2x.cpp: LGPL (v2.1 or later)
[+] license file is included in %doc:
[+] spec file is in American English
[+] spec file is legible
[+] sources match upstream: md5sum matches (e8b20e62bbbb061b1a59d51b47c827bd)
[+] package builds on at least one primary arch:
[N] appropriate use of ExcludeArch
[+] all build requirements in BuildRequires
[N] spec file handles locales properly
[N] ldconfig in %post and %postun
[+] no bundled copies of system libraries
[+] no relocatable packages
[+] package owns all directories that it creates
[+] no files listed twice in %files
[+] proper permissions on files
[+] consistent use of macros
[+] code or permissible content
[N] large documentation in -doc
[+] no runtime dependencies in %doc
[N] header files in -devel
[N] static libraries in -static
[N] .so in -devel
[N] -devel requires main package
[+] package contains no libtool archives
[+] package contains a desktop file, uses desktop-file-install/validate
[+] package does not own files/dirs owned by other packages
[+] all filenames in UTF-8

SHOULD:
[?] query upstream for license text
Didn't query
[?] description and summary contains available translations
No explicit need, no need to fix
[+] package builds in mock:
Works with i686
[+] package builds on all supported arches
Works in x86_64 and i686
[+] package functions as described
One game tested, no issues, perfect run time.
[+] sane scriptlets
[N] subpackages require the main package
[N] placement of pkgconfig files
[N] file dependencies versus package dependencies
[+] package contains man pages for binaries/scripts

COMMENTS:
-The license issue should be fixed, with a license breakdown and all that.
-I would suggest that patch 1 should be sent upstream, if it hasn't already.
-Since this provides fceultra, gfceu is never removed upon update. Either the
fceultra should be removed or an obsoletes gfceu should be added.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.