[Bug 2298] Review request: fceux - A cross platform, NTSC and PAL Famicom/NES emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2298

--- Comment #3 from Andrea Musuruane <musuruan at gmail.com> 2012-04-27 19:35:22 CEST ---
(In reply to comment #2)
> Package review:

Thanks for the quick review, Jeremy!
> -The license issue should be fixed, with a license breakdown and all that.

Both BSD and LGPLv2+ are compatible with GPLv2+. So it is perfectly fine for
upstream to license the sources as GPLv2+.

Please see, for example:
https://en.wikipedia.org/wiki/License_compatibility#GPL_compatibility

> -I would suggest that patch 1 should be sent upstream, if it hasn't already.

I haven't. I'll check if SVN HEAD doesn't yet have this change first.

> -Since this provides fceultra, gfceu is never removed upon update. Either the
> fceultra should be removed or an obsoletes gfceu should be added.

OK. I will obsolete gfceu too.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.