[Bug 2017] Review request: gnome-shell-extension-weather - An extension for displaying weather notifications in GNOME Shell

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2017

--- Comment #49 from leigh scott <leigh123linux at gmail.com> 2012-08-19 12:29:13 CEST ---
(In reply to comment #48)
----------------------------------------------------------------------

Message: 1
Date: Sat, 18 Aug 2012 19:41:06 +0200
From: Mattia <hal8600 at hotmail.it>
To: rpmfusion-developers at lists.rpmfusion.org
Subject: gnome-shell-extension-weather: build failed
Message-ID: <BLU0-SMTP2910CFB3F7EF0CFFC05574FD8BB0 at phx.gbl>
Content-Type: text/plain; charset="iso-8859-1"

I tried to build gnome-shell-extension-weather (branches: *devel*, *F-16*, *
F-17*) on Plague, but all builds failed. Here are the logs:

 *
http://buildsys.rpmfusion.org/logs/fedora-development-rpmfusion_free/14212-gnome-shell-extension-weather-0-0.4.gitb9358f2.fc18/
*
http://buildsys.rpmfusion.org/logs/fedora-16-rpmfusion_free/14213-gnome-shell-extension-weather-0-0.4.gitb9358f2.fc16/
*
http://buildsys.rpmfusion.org/logs/fedora-17-rpmfusion_free/14214-gnome-shell-extension-weather-0-0.4.gitb9358f2.fc17/

*Mock* on my local machine built the package (for Fedora 17 x86_64) with
success. The results of *mock* are inside this archive:
http://db.tt/qTbAvgDm

Any suggestions on what to do?
Thank you.

Regards,
M.M.
-------------- next part --------------



How did this package past review with this or was it added later?

%build
./autogen.sh --prefix=/usr
make %{?_smp_mflags}



I sent you an email

-------- Original Message --------
Subject:     gnome-shell-extension-weather
Date:     Sun, 19 Aug 2012 11:21:41 +0100
From:     Leigh Scott <leigh123linux at gmail.com>
To:     hal8600 at hotmail.it


Hi,




Try this

%build
NOCONFIGURE=1 ./autogen.sh
%configure --prefix=%{_prefix}
make %{?_smp_mflags}


Leigh


P.S your previous %build section breached guidelines on many counts

This is bad on to counts

1. using ./autogen to configure is bad as it does set any variables
2. no hard paths allowed /usr , always use the proper macros

 Always use %configure as it sets everything

$ rpm -E %configure

  CFLAGS="${CFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 
-fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 
-mtune=generic}" ; export CFLAGS ;
  CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 
-fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 
-mtune=generic}" ; export CXXFLAGS ;
  FFLAGS="${FFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 
-fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 
-mtune=generic -I/usr/lib64/gfortran/modules}" ; export FFLAGS ;
  LDFLAGS="${LDFLAGS:--Wl,-z,relro }"; export LDFLAGS;
  ./configure --build=x86_64-unknown-linux-gnu 
--host=x86_64-unknown-linux-gnu \
    --program-prefix= \
    --disable-dependency-tracking \
    --prefix=/usr \
    --exec-prefix=/usr \
    --bindir=/usr/bin \
    --sbindir=/usr/sbin \
    --sysconfdir=/etc \
    --datadir=/usr/share \
    --includedir=/usr/include \
    --libdir=/usr/lib64 \
    --libexecdir=/usr/libexec \
    --localstatedir=/var \
    --sharedstatedir=/var/lib \
    --mandir=/usr/share/man \
    --infodir=/usr/share/info

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.