[Bug 2017] Review request: gnome-shell-extension-weather - An extension for displaying weather notifications in GNOME Shell

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2017

--- Comment #50 from leigh scott <leigh123linux at gmail.com> 2012-08-19 12:33:00 CEST ---
-------- Original Message --------
Subject:     Fwd: gnome-shell-extension-weather
Date:     Sun, 19 Aug 2012 11:32:15 +0100
From:     Leigh Scott <leigh123linux at gmail.com>
To:     hal8600 at hotmail.it


I made a couple of minor mistakes in my original email




Hi,




Try this

%build
NOCONFIGURE=1 ./autogen.sh
%configure --prefix=%{_prefix}
make %{?_smp_mflags}


Leigh


P.S your previous %build section breached guidelines on many counts

This is bad on 2 counts

1. using ./autogen to configure is bad as it doesn't set any variables
2. no hard paths allowed /usr , always use the proper macros

 Always use %configure as it sets everything

$ rpm -E %configure

  CFLAGS="${CFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64
-mtune=generic}" ; export CFLAGS ;
  CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64
-mtune=generic}" ; export CXXFLAGS ;
  FFLAGS="${FFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64
-mtune=generic -I/usr/lib64/gfortran/modules}" ; export FFLAGS ;
  LDFLAGS="${LDFLAGS:--Wl,-z,relro }"; export LDFLAGS;
  ./configure --build=x86_64-unknown-linux-gnu
--host=x86_64-unknown-linux-gnu \
    --program-prefix= \
    --disable-dependency-tracking \
    --prefix=/usr \
    --exec-prefix=/usr \
    --bindir=/usr/bin \
    --sbindir=/usr/sbin \
    --sysconfdir=/etc \
    --datadir=/usr/share \
    --includedir=/usr/include \
    --libdir=/usr/lib64 \
    --libexecdir=/usr/libexec \
    --localstatedir=/var \
    --sharedstatedir=/var/lib \
    --mandir=/usr/share/man \
    --infodir=/usr/share/info

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.