[Bug 2098] Review request: dolphin-emu - Gamecube / Wii / Triforce Emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098

--- Comment #27 from Jeremy Newton <alexjnewt at hotmail.com> 2012-02-24 00:58:20 CET ---
(In reply to comment #26)
> Woke up, had a bad feeling about these bundled headers.
> 
> First, hci.h and l2cap.h is possibly just the tip of the iceberg. If you run
> script below, you will find a list of candidates. There are plenty of false
> positives, but also some files to take care about. Note that the script
> requires relevant -devel packages installed, but I guess you have :)
> 
> Secondly, symlinking was a bad idea. What you should do is to just remove these
> files in %prep and setup compiler flags so the system headers are used instead.
> A long time since I used cmake, but I *think* something like this could work:
> 
> export CFLAGS="-I/usr/include/ffmpeg -I/usr/include/bluetooth ..."
> %cmake  ...
> 
> Find headers hack:
> 
> #!/bin/bash
> for header in $(find  Source -name \*.h); do
>     basename=$( basename $header );
>     sys_headers=$( find /usr/include -name $basename)
>     test -n "$sys_headers" && {
>         echo "$header"
>         for sh in $( echo $sys_headers ); do
>             echo "    $sh"
>         done
>     }
> done

Though I thank you for the script, after running this, I can't confirm any
bundled headers. In fact all the headers that came up were false positives
including those Bluetooth files. Not only were they not equivalent code, but
also were dolphin specific and had two sets of different licenses, copyrights
and authors.

At the moment, if I am not mistaken, I don't see any bundled libraries besides
those listed in Externals. I'll have to look into packaging these libraries or
getting an exception for Dolphin, as I have yet to look into what these
libraries are.

(In reply to comment #16)
> > 6.  A number of files have BSD licenses. Shouldn't these be part of
> >     License tag like in "GPLv2 and BSD" or similar?
> 
> I must have missed that, I'll look into that and fix it.
> 

It seems that in hunting for those BSD licensed files, I found some OpenSSL
licensed files and IIRC, OpenSSL conflicts with GPL. Depending on how the code
works, this may be a big problem; I'll have to contact upstream about this.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.