[Bug 2472] Review request: gstreamer1-libav - GStreamer 1.0 FFmpeg-based plug-ins

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2472

--- Comment #12 from Andrea Musuruane <musuruan at gmail.com> 2012-10-28 17:40:25 CET ---
Hans, these are the CFLAGS actually used:

-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4  -m64 -mtune=generic   -std=c99 -fomit-frame-pointer
-fPIC -pthread -g -Wdeclaration-after-statement -Wall -Wno-parentheses
-Wno-switch -Wno-format-zero-length -Wdisabled-optimization -Wpointer-arith
-Wredundant-decls -Wno-pointer-sign -Wcast-qual -Wwrite-strings -Wtype-limits
-Wundef -Wmissing-prototypes -Wstrict-prototypes -O3 -fno-math-errno
-fno-signed-zeros -fno-tree-vectorize -Werror=implicit-function-declaration
-Werror=missing-prototypes -Werror=declaration-after-statement 

As you can see the first part is composed by the standard Fedora optflags. In
the second part there are other flags. One in particular caught my attention:
the "-O3" that overrides the "-O2". This is not permitted by Fedora Guidelines. 

(In reply to comment #11)
> Andrea, can you perhaps also review the gstreamer1-plugins-bad-freeworld
> package ? See bug 2473, I'll happily swap another review for it.

I can but later this week. Is it OK for you? If so, you can take #1798. Thanks!

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.