[Bug 2472] Review request: gstreamer1-libav - GStreamer 1.0 FFmpeg-based plug-ins

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2472

--- Comment #13 from Hans de Goede <j.w.r.degoede at gmail.com> 2012-10-28 19:26:27 CET ---
Hi,

(In reply to comment #12)
> Hans, these are the CFLAGS actually used:
> 
> -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
> --param=ssp-buffer-size=4  -m64 -mtune=generic   -std=c99 -fomit-frame-pointer
> -fPIC -pthread -g -Wdeclaration-after-statement -Wall -Wno-parentheses
> -Wno-switch -Wno-format-zero-length -Wdisabled-optimization -Wpointer-arith
> -Wredundant-decls -Wno-pointer-sign -Wcast-qual -Wwrite-strings -Wtype-limits
> -Wundef -Wmissing-prototypes -Wstrict-prototypes -O3 -fno-math-errno
> -fno-signed-zeros -fno-tree-vectorize -Werror=implicit-function-declaration
> -Werror=missing-prototypes -Werror=declaration-after-statement 
> 
> As you can see the first part is composed by the standard Fedora optflags. In
> the second part there are other flags. One in particular caught my attention:
> the "-O3" that overrides the "-O2". This is not permitted by Fedora Guidelines. 
> 

This is only the case for the included / bundled libav copy, not for the actual
gstreamer code. And I just double checked and rpmfusion's own ffmpeg packages
are build the same way. I guess this is a case of upstream knows best, as this
is quite performance sensitive code and upstream seems to go through
a great deal of trouble to get certain cflags passed and explictly disables
some problematic optimizations.

If you really believe this is an issue.  I belief the proper way forward with
this
is to file a bug against the ffmpeg package, and if / when that gets fixed
I'll duplicate the fix in the gstreamer-ffmpeg and gstreamer1-libav packages,
in the mean time I would like to move forward with this review though.


> (In reply to comment #11)
> > Andrea, can you perhaps also review the gstreamer1-plugins-bad-freeworld
> > package ? See bug 2473, I'll happily swap another review for it.
> 
> I can but later this week. Is it OK for you? If so, you can take #1798. Thanks!

Yes that works for me. I'll go work on bug 1798 right away.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.