[Bug 1798] Review request: pyskool - Remakes of Skool Daze and Back to Skool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1798

Hans de Goede <j.w.r.degoede at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |j.w.r.degoede at gmail.com
             Blocks|2                           |4
         AssignedTo|rpmfusion-package-review at rp |j.w.r.degoede at gmail.com
                   |mfusion.org                 |

--- Comment #1 from Hans de Goede <j.w.r.degoede at gmail.com> 2012-10-28 19:56:25 CET ---
Full review done:

Good:
====
- rpmlint checks return:
rpmlint rpmbuild/RPMS/noarch/pyskool-0.6-1.fc18.noarch.rpm
rpmbuild/SRPMS/pyskool-0.6-1.fc18.src.rpm 
pyskool.noarch: W: invalid-license proprietary
pyskool.src: W: invalid-license proprietary
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv3+ and proprietary) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code + necessary content
- no need for -docs
- nothing in %doc affects runtime
- .desktop files properly installed

Should fix:
=======
The following lines in %files
%doc COPYING docs/*
Also causes the following to be installed under /usr/share:
/usr/share/doc/pyskool-0.6/_sources/ai.txt
...
/usr/share/doc/pyskool-0.6/_sources/water.txt
Which are not referred to by any of the installed html files (unlike the
content
under _static which is used).

No blockers: *Approved*

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.