Bundling exception for dhewm3

[Antonio Trande]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/06/2013 04:17 PM, Simone Caronni wrote:
> Following review at:
> 
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=3035
> 
> I'm asking for a bundling exception for MiniZip in the dhewm3
> package.
> 
> ID Software added a function to MiniZip that is required for the
> engine to open game data archive files:
> 
> https://github.com/dhewm/dhewm3/blob/master/neo/framework/minizip/unzip.cpp#L68
>
> 
https://github.com/dhewm/dhewm3/blob/master/neo/framework/minizip/unzip.cpp#L2159
> 
> Upstream dhewm3 developers have been very keen on removing bundled 
> libraries but this can't be removed due to the added function:
> 
> https://github.com/dhewm/dhewm3/pull/88#issuecomment-29705454
> 
> They have nevertheless removed all extra custom functions that have
> been later integrated into official MiniZip; updated it to avoid
> clashes and made adjustments to enable merging a newer MiniZip
> easily if that is required.
> 

Well, it seems to me that none is disagree with an inclusion of a
customized MiniZip, therefore we can finish the package review.
- -- 


Antonio Trande

mailto: sagitter at fedoraproject.org
http://www.fedoraos.worpress.com
https://fedoraproject.org/wiki/User:Sagitter
GPG Key: D400D6C4
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSqeCuAAoJED2vIvfUANbEumUP/3pEphYnF/tJOnJe1frIMnjq
AJSqV7JpnQgP481xYqCmY8L37VEWKZZHy1riV/xPfHb6S2PKmCoV2zZJcEeTNson
7IIlfA9j2po3bFEKozi9y6RQeXmxY4oQC3WqP6l0i+GRy/qTOu8j/Hvf/6N0GO9F
jI7vSqgjqKuE4HyviotIqjDbLSkRDe3ScD4S+T+VwC02jNlheZoE4/VlsyxMOgk7
QjN9RSkTxY8f/vKzeX9IN5ct4DQAfrdsrrEBS+/l6ZwOSEMLa5avxU43jzg+2hjd
Sjjhd9OAUNxKLqjutt91V3mVSUT6MOOo+NTOzfi512Yc657btpPnPy4+Og1v8HK6
tu7bLiWjpBoW8T958aKUFAM4m/eY9sG0J7o1p7+s0NP1KZL4aySFuLb+vcvp9ROG
sWhB5DI/zhxyZrjdwiTcccSBp11nRB6i0VI/MbyfyXtqAKrYY5g0fhMhMXNAbTRK
mIG6+6GzvaJFAhv7vbSqFqWXSmmL6DBXgkSMWg0lzgLozwgRbieo32cJG4ZLWXRM
S2jwnammMB4NOV9iMDlqdGvdqLto73iNE7Au6EpQ5QsvECyMAMGWlCjyDWCfDA/4
UiRHecjSO/aLcwXkJ8WaKBJTDE8c+UgYmjjm88BSZfweIZ27KWT82Mjh19OJu1Gl
PzPr09DDIQ1m8VP/IZKf
=BZKs
-----END PGP SIGNATURE-----