[Bug 3282] Review Request: x265 - H.265/HEVC encoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3282

--- Comment #13 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net> 2014-07-17 11:37:18 CEST ---
(In reply to comment #11)
> The 'tr' usage to fix the end of lines of the .bat is incorrect :
> + tr -d '\r' doc/uncrustify/drag-uncrustify.bat
> tr: extra operand 'doc/uncrustify/drag-uncrustify.bat'
> 
> It leads to the following rpmlint errors : 
> x265-devel.i686: E: zero-length
> /usr/share/doc/x265-devel/uncrustify/drag-uncrustify.bat.unix
> x265-devel.i686: W: wrong-file-end-of-line-encoding
> /usr/share/doc/x265-devel/uncrustify/drag-uncrustify.bat
> 
> It's probably easier to use sed :
> https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding

That was a missing '<'. Fixed.

> The package now builds on i686 at the price of the following rpmlint warning :
> x265.src: W: %ifarch-applied-patch Patch1: x265-test-shared.patch

Which is harmless.

> The following rpmlint warning probably also needs to be looked at :
> x265-libs.i686: E: shlib-with-non-pic-code /usr/lib/libx265.so.1.2

I added -fPIC to compilation flags on i686, but despite this, the warning is
still there. Probably some of the assembly code is non-PIC on i686. I'll have
to take this upstream.

Spec URL: http://mokona.greysector.net/~rathann/rpmfusion/x265.spec
SRPM URL:
http://mokona.greysector.net/~rathann/rpmfusion/x265-1.2-3.fc20.src.rpm

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.