[Bug 3429] Review request: frobtads - Text interpreter for Tads games

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3429

Hans de Goede <j.w.r.degoede at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|2                           |3

--- Comment #2 from Hans de Goede <j.w.r.degoede at gmail.com> 2015-12-28 15:58:36 CET ---
Full review done:

Good:
====
- rpmlint checks return:
[hans at shalem rpmbuild]$ rpmlint SRPMS/* RPMS/x86_64/*
frobtads.src: W: invalid-license non-commercial
frobtads.src:12: W: unversioned-explicit-provides bundled(md5-deutsch-c++)
frobtads.src:13: W: unversioned-explicit-provides bundled(sha2-gladman)
frobtads.x86_64: W: invalid-license non-commercial
frobtads-debuginfo.x86_64: W: invalid-license non-commercial
frobtads-devel.x86_64: W: invalid-license non-commercial
4 packages and 0 specfiles checked; 0 errors, 6 warnings.
 These can all be ignored
- package meets naming guidelines
- package meets packaging guidelines
- license (non-commercial) OK, matches source
- spec file legible, in am. english
- source matches upstream
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Needs work:
========
-license text not in %license, the actual license text is in tads3/LICENSE.TXT
so the %license line should read:
 %license doc/COPYING tads3/LICENSE.TXT
-Package does not build, this is caused by you moving the installed tads manual
to %{_pkgdocdir}-devel
 but not having a matching %doc line in %files. For the review I've fixed this
by replacing the mkdir + mv
 you do after make install with:
rm -rf %{buildroot}%{_datadir}/frobtads/tads3/doc
 and adding the docs in question to "%files devel" like this:
%doc doc/COMPILERS tads3/doc/*
 Letting rpmbuild take care if the installation of the docs, which usually is
the best way to deal with docs
-Why is %{_datadir}/frobtads/tads2 owned by the -devel pkg and not by the main
pkg ?

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.