[Bug 3430] Review request: qtads - Multimedia interpreter for Tads games

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3430

Hans de Goede <j.w.r.degoede at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|2                           |4

--- Comment #2 from Hans de Goede <j.w.r.degoede at gmail.com> 2015-12-28 16:33:38 CET ---
Full review done:

Good:
=====
- rpmlint checks return:
qtads.src: W: invalid-license non-commercial
qtads.src: W: invalid-license non-commercial
qtads.src:25: W: unversioned-explicit-provides bundled(md5-deutsch-c++)
qtads.src:26: W: unversioned-explicit-provides bundled(sha2-gladman)
qtads.x86_64: W: invalid-license non-commercial
qtads.x86_64: W: invalid-license non-commercial
qtads-debuginfo.x86_64: W: invalid-license non-commercial
qtads-debuginfo.x86_64: W: invalid-license non-commercial
3 packages and 0 specfiles checked; 0 errors, 8 warnings.
 These can all be ignored
- package meets naming guidelines
- package meets packaging guidelines
- license (non-commercial) OK, text in %license, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file provided and properly installed


Everything in order: Approved.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.