was -> wasn't Re: [VirtualBox] Use systemd-detect-virt to detect if we can install

[Sérgio Basto]

On Ter, 2016-11-29 at 18:46 +0000, Sérgio Basto wrote:
> Hi,
> 
> On Ter, 2016-11-29 at 14:17 +0100, Dominik 'Rathann' Mierzejewski
> wrote:
> > 
> > 
> > Hi Sérgio,
> > could you explain the idea here? Why was there an explicit
> > Conflicts:
> > before and why is it better to fail the transaction if you're not
> > running inside VirtualBox or KVM?
> It is a long story, bug reports about this [2]. With this solution
> (which took sometime to figure out), we can install VirtualBox-guest
> and VirtualBox in a vm guest [1] I think in middle of bug 3425 , I
> realize that the root of the problem is we can't install VirtualBox-
> guest-additions in master (host) system because breaks X11, etc . 
> So instead use an artificial rpm conflicts, BTW the solution *wasn't*
> made
> my me, it was already there when I arrived, I check in %pre if 
> 
>    $(systemd-detect-virt | grep -iP "oracle|kvm" -c) -eq 0
> 

    dmidecode -s bios-version 

could be an alternative 

> if systemd-detect-virt doesn't say that is in one oracle or kvm vm ,
> I
> don't let package (VirtualBox-guest-additions) be installed .
> 
> I also check kvm because in epel7 vbox vm, systemd-detect-virt says
> that is in kvm instead oracle ...
>  
> From now on, we may install VirtualBox and VirtualBox-guest-additions
> under a vm , that is the main goal of this change . 
> 
> Have you any suggestion or something where I can improve ? 
> 
> > 
> > 
> >  Also, what if calling systemd-detect-virt
> > fails for some reason?
> packages requires systemd 
> %{?systemd_requires}
> BuildRequires: systemd
> 
> if systemd-detect-virt doesn't work we should be fixed , one La
> Palice
> answer :) . 
> 
> > 
> > 
> > Regards,
> > Dominik
> [1] 
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=3425#c7
> 
> [2]
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=3425
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=3426
> 
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=1357
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=1468
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=2430
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=2442
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=2722
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=3126
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=3506
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=3918
> 
> Cheers,
-- 
Sérgio M. B.