[Bug 4361] Review Request: HandBrake - An open-source multiplatform video transcoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4361

--- Comment #1 from Nicolas Chauvet <kwizart at gmail.com> ---
Few comments:
- Does it really uses the bundled fdk-aac instead of the internal ffmpeg aac
encoder ?
# Use system libraries in place of bundled ones
for module in a52dec %{?_with_fdk:fdk-aac}
...
- We cannot rely on this currently (we might need to restart the discussion)
At least it should be dlopenable.
Requires:       libdvdcss%{_isa}

- What is the point to have -gui -tui separation without any main package ?
I would use handbrake (main) as the default (-gui) package and use -core or
keep -tui as a sub-package.
(even using a virtual provide for lower case handbrake compatibility if not
handled by dnf already).

- Using , %make_build, %make_install, missing BR gcc, gcc-c++

- Remove dependency that are in the default BR (m4, patch, Makefile, etc)

- No appdata ?

Thx for this submit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.rpmfusion.org/pipermail/rpmfusion-developers/attachments/20161130/cf92b575/attachment.html>