[Bug 1742] Review Request: vo-aacenc - VisualOn AAC encoder library

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1742

--- Comment #24 from Hans de Goede <j.w.r.degoede at gmail.com> ---
(In reply to rc040203 from comment #22)
> (In reply to Hans de Goede from comment #21)
> 
> - MUSTFIX: Building is non-verbose
> Please append --disable-silent-rules to %configure

Fixed in 0.1.3-2

> - /usr/lib64/pkgconfig/vo-aacenc.pc seems broken to me.
> 
> It uses includedir=/usr/include,

Right, vo-amrwbenc does the same thing, the users expect to need to do:

#include <vo-amrwbenc/enc_if.h>

I just tried building gstreamer1-plugins-bad-freeworld with vo-aacenc support
enabled and that works fine.

> - Consider to remove the "rm -rf %{buildroot}" from %install
> It's not needed anymore unless you plan to build this package for really
> ancient rhels.

Fixed in 0.1.3-2

> - Consider to remove the "Group" tags. They aren't used for anything in
> Fedora.

Fixed in 0.1.3-2

Here is 0.1.3-2 :

* Sat Sep 17 2016 Hans de Goede <j.w.r.degoede at gmail.com> - 0.1.3-2
- Pass --disable-silent-rules to %%configure
- Drop obsolete Group tags, rm -rf %%{buildroot}
- Use %%make_install

http://jwrdegoede.danny.cz/vo-aacenc.spec
http://jwrdegoede.danny.cz/vo-aacenc-0.1.3-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.rpmfusion.org/pipermail/rpmfusion-developers/attachments/20160917/908c171f/attachment.html>