[Bug 527] New: Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
10:46 a.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Summary: Review request: mlt - Toolkit for broadcasters, video
editors, media players, transcoders
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: zarko.pintar(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Estimated Hours: 0.0
Spec:
http://wiki.open.hr/~zpintar/fedora10/RPMFusion/SPECS/mlt.spec
Source:
http://wiki.open.hr/~zpintar/fedora10/RPMFusion/SRPMS/mlt-0.3.6-2.fc10.sr...
Description:
MLT is an open source multimedia framework, designed
and developed for television broadcasting.
It provides a toolkit for broadcasters, video editors,
media players, transcoders, web streamers and many more
types of applications. The functionality of the system
is provided via an assortment of ready to use tools,
xml authoring components, and an extendible plug-in
based API.
This package hardly depend on ffmpeg library (without them is mostly useless),
so this is the main reason why I put them here.
rpmlint - mlt
--------------
mlt.i386: W: shared-lib-calls-exit /usr/lib/libmiracle.so.0.3.7 exit(a)GLIBC_2.0
mlt.x86_64: W: shared-lib-calls-exit /usr/lib64/libmiracle.so.0.3.7
exit(a)GLIBC_2.2.5
8 packages and 0 specfiles checked; 0 errors, 2 warnings.
This warning will be removed by the author of MLT source in next release (for
two weeks from now)
No more warnings in source and binary RPMs.
Package tested with mock for i386 and x86_64 architectures.
This is one of my first packages on RPM Fusion.
On Fedora I put four packages last month. But I'm not yet sponsored there, so I
seeking for sponsor here.
kind regards,
Zarko
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:57 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Zarko Pintar <zarko.pintar(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |528
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:58 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Zarko Pintar <zarko.pintar(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |30
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:09 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Zarko Pintar <zarko.pintar(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |529
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:39 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Orcan Ogetbil <oget.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oget.fedora(a)gmail.com
--- Comment #1 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-08 20:39:24 ---
A few initial notes:
* Can't we enable mmx at least for x86_64 ?
* Please make use of the %{name} macro for consistency. For instance,
%{_libdir}/%{name}
%{_datadir}/mlt
in %files is not good.
* Please make the description span 80 columns.
* In %files devel
%doc docs/
should probably be
%doc docs/*
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:27 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #2 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-09 08:27:49 ---
(In reply to comment #1)
A few initial notes:
* Can't we enable mmx at least for x86_64 ?
Yes we can :) Enabled is now
* Please make use of the %{name} macro for consistency. For instance,
* Please make the description span 80 columns.
should probably be
%doc docs/*
It is done.
New spec and source:
http://wiki.open.hr/~zpintar/fedora10/RPMFusion/SPECS/mlt.spec
http://wiki.open.hr/~zpintar/fedora10/RPMFusion/SRPMS/mlt-0.3.6-3.fc10.sr...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:12 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #3 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-11 21:12:18 ---
(In reply to comment #2)
(In reply to comment #1)
> A few initial notes:
>
> * Can't we enable mmx at least for x86_64 ?
Yes we can :) Enabled is now
Okay, but we don't want that for ppc/ppc64 architectures. Now, looking at the
configure script I don't see a --enable-mmx flag. It is already enabled by
default. You just need to disable it for certain architectures, which would be
ppc and ppc64. Additionally you may want to disable sse for older ix86
architectures (i586 and below). We will probably need something like
ExclusiveArch: i586 i686 x86_64 ppc ppc64
Rathann and Nicolas are more experienced in these things. I hope they will give
a more complete information.
Btw, is the demo/ directory worth including in the %doc of the devel
subpackage?
The group for the main package should probably be System Environment/Libraries.
Right?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:17 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #4 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-11 23:17:17 ---
Okay, but we don't want that for ppc/ppc64 architectures. Now, looking at the
configure script I don't see a --enable-mmx flag. It is already enabled by
default. You just need to disable it for certain architectures, which would be
ppc and ppc64. Additionally you may want to disable sse for older ix86
architectures (i586 and below). We will probably need something like
ExclusiveArch: i586 i686 x86_64 ppc ppc64
OK, I can make something like this:
%configure \
--enable-gpl \
--enable-motion-est \
%ifarch ppc ppc64
--disable-mmx \
%endif
--qimage-libdir=%{_qt4_libdir} \
--qimage-includedir=%{_qt4_headerdir} \
--avformat-swscale
Zarko
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:34 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #5 from Kevin Kofler <kevin.kofler(a)chello.at> 2009-04-12 11:34:25 ---
If there's no runtime detection, enabling MMX on i586 breaks old 586-class CPUs
(e.g. the original Pentium).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:17 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #6 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-13 04:17:03 ---
(In reply to comment #5)
If there's no runtime detection, enabling MMX on i586 breaks old
586-class CPUs
(e.g. the original Pentium).
Yes, but the question is: Does this software need to support such old hardware?
Is it worth?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:23 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Jarod Wilson <jarod(a)wilsonet.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jarod(a)wilsonet.com
--- Comment #7 from Jarod Wilson <jarod(a)wilsonet.com> 2009-04-13 05:23:04 ---
(In reply to comment #6)
(In reply to comment #5)
> If there's no runtime detection, enabling MMX on i586 breaks old 586-class CPUs
> (e.g. the original Pentium).
>
Yes, but the question is: Does this software need to support such old hardware?
Is it worth?
My $.02 USD: enable MMX, screw the 586 users. Anyone still using 586-class
hardware really has no business running a video editor. Hell, at least enabling
MMX might make it bearable to use on a P-III or something... Of course, I'm a
64-bit snob -- I'm still amazed how many people don't run 64-bit hardware yet.
;)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:55 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Jussi Lehtola <jussi.lehtola(a)iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jussi.lehtola(a)iki.fi
--- Comment #8 from Jussi Lehtola <jussi.lehtola(a)iki.fi> 2009-04-13 09:55:52 ---
(In reply to comment #7)
(In reply to comment #6)
> (In reply to comment #5)
> > If there's no runtime detection, enabling MMX on i586 breaks old 586-class
CPUs
> > (e.g. the original Pentium).
> >
>
> Yes, but the question is: Does this software need to support such old hardware?
> Is it worth?
My $.02 USD: enable MMX, screw the 586 users. Anyone still using 586-class
hardware really has no business running a video editor. Hell, at least enabling
MMX might make it bearable to use on a P-III or something... Of course, I'm a
64-bit snob -- I'm still amazed how many people don't run 64-bit hardware yet.
;)
I agree. MMX is found on everything from Pentium MMX up. If there is still
someone running an original Pentium (max freq 200MHz), s/he'll be happy with
Fedora still being able to install [in less than 24 hours]. The hardware's 13
years old!
Of course, if you want to be extra courteous, you can make a -nommx package,
although I severely doubt whether anyone would be using it :)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:30 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #9 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-13 11:30:33 ---
(In reply to comment #6)
(In reply to comment #5)
> If there's no runtime detection, enabling MMX on i586 breaks old 586-class CPUs
> (e.g. the original Pentium).
>
Yes, but the question is: Does this software need to support such old hardware?
Is it worth?
MLT, Kdenlive, Video editing are things bonded to new class processors (newer
then old 586s).
My standing is disable MMX only on PPC and PPC64 architectures...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:09 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #10 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-13 16:09:12 ---
Now I reslove MMX problem, and demo files.
The group for the main package should probably be System
Environment/Libraries.
Right?
MLT is a framework, so it is a development staff. I think that group for MLT
must stay Development/Libraries instead of System Environment.
New spec and source:
http://wiki.open.hr/~zpintar/fedora10/RPMFusion/SPECS/mlt.spec
http://wiki.open.hr/~zpintar/fedora10/RPMFusion/SRPMS/mlt-0.3.6-3.fc10.sr...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:55 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kwizart(a)gmail.com
--- Comment #11 from NicolasChauvet <kwizart(a)gmail.com> 2009-04-14 11:55:38 ---
freir0-plugins is now available in fedora.
According to our packaging standard, there is a need to search for 64bit dso in
/usr/lib64. But the freir0 api doesn't obbey to this rule.
This probably need to be tweaked in the related application...
(I can have a look if needed).
http://koji.fedoraproject.org/koji/taskinfo?taskID=1296849
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:02 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #12 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-14 12:02:55 ---
(In reply to comment #11)
freir0-plugins is now available in fedora.
Good! :)
So, I'll add frei0r-plugins into mlt build.
Currently, I'm preparing my development environment (mock and other staff) for
use with upcoming Fedora 11 and gcc 4.4.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:55 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #13 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-15 15:55:37 ---
- New MLT version 0.3.8
- Tested for upcoming Fedora 11
- Rpmlint:
mlt.i586: W: shared-lib-calls-exit /usr/lib/libmiracle.so.0.3.8
exit(a)GLIBC_2.0
mlt-devel.i586: W: spurious-executable-perm
/usr/share/doc/mlt-devel-0.3.8/demo/demo
mlt-devel.i586: W: doc-file-dependency
/usr/share/doc/mlt-devel-0.3.8/demo/demo /bin/bash
Spec:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SPECS/mlt.spec
Source:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SRPMS/mlt-0.3.8-1.fc11.s...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:21 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Orcan Ogetbil <oget.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3
Status|NEW |ASSIGNED
--- Comment #14 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-16 07:21:23 ---
Since you got sponsored, things can go faster now. Here is a more thorough
review:
* rpmlints:
mlt.i586: W: shared-lib-calls-exit /usr/lib/libmiracle.so.0.3.8
exit(a)GLIBC_2.0
So this isn't removed in this release. What happened?
mlt-devel.i586: W: spurious-executable-perm
/usr/share/doc/mlt-devel-0.3.8/demo/demo
mlt-devel.i586: W: doc-file-dependency
/usr/share/doc/mlt-devel-0.3.8/demo/demo /bin/bash
These two can be eliminated by doing a
chmod -x demo/demo
in %prep.
* Shouldn't group tag for the main package be System Environment/Libraries ?
! All relevant doc files should be packaged. ./src/modules/motion_est/README
can go to the %doc of the main package
* Please add BuildRequires: frei0r-devel
* src/modules/jackrack/plugin_mgr.c has
/usr/local/lib/ladspa:/usr/lib/ladspa
hardcoded, which won't work on 64bit systems. Please fix this.
? Why do you rename all the executables but "inigo"?
* rawhide buildlog says:
- libquicktime not found: only enabling dv avi support
This is because it can't find lqt-config. See:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=265
http://cvs.rpmfusion.org/viewvc/rpms/libquicktime/devel/libquicktime.spec...
You need to patch this up so it can find the libquicktime properly.
* Similarly, mlt-config shouldn't be packaged (the file itself says it is
deprecated) or it will break multilib. You can use %exclude in %files to
exclude it.
* I don't think you need these lines in the SPEC:
BuildRequires: prelink
and
# clear-execstack
execstack -c $RPM_BUILD_ROOT%{_libdir}/%{name}/libmltgtk2.so
* I also think that you don't need this
BuildRequires: alsa-lib-devel
* Each package must consistently use macros, as described in the macros section
of Packaging Guidelines .
Please make use of the %{name} macro extensively (except maybe URL), or do not
use it at all.
* Running mlt-miracle gives "segmentation fault"
! SPEC file improvement: You don't needs these lines
install -d docs/demo
cp -p demo/* docs/demo
Adding "demo" after "docs/*" will be sufficient. i.e.
...
%files devel
%defattr(-,root,root,-)
%doc docs/* demo
...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:21 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #15 from NicolasChauvet <kwizart(a)gmail.com> 2009-04-16 10:21:57 ---
*
* src/modules/jackrack/plugin_mgr.c has
/usr/local/lib/ladspa:/usr/lib/ladspa
hardcoded, which won't work on 64bit systems. Please fix this.
The same would be
needed for frei0r-plugins
* I'm not fund of extensive usage of the %{name} macro.
* Similarly, mlt-config shouldn't be packaged (the file itself
says it is
deprecated) or it will break multilib. You can use %exclude in %files to
exclude it.
I other words; you need to use pkg-config libquicktime.pc
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:57 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #16 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-16 10:57:04 ---
(In reply to comment #14)
* rpmlints:
mlt.i586: W: shared-lib-calls-exit /usr/lib/libmiracle.so.0.3.8
exit(a)GLIBC_2.0
So this isn't removed in this release. What happened?
* Running mlt-miracle gives "segmentation fault"
I forwarded this problems to author of upstream
One of solution is dropping mlt-miracle from package...
? Why do you rename all the executables but "inigo"?
This renaming happened earlier, when MLT was on Fedora repo. See:
https://bugzilla.redhat.com/show_bug.cgi?id=459979#c10
but, I can rename inigo to mlt-inigo, too.
* Each package must consistently use macros, as described in the
macros section
of Packaging Guidelines .
Please make use of the %{name} macro extensively (except maybe URL), or do not
use it at all.
Hmm, I don't understand well, where I exactly did not use %{name} macro, except
at renaming and renamed binaries...
I'll apply your suggestions and update MLT revision very soon...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:12 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #17 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-16 17:12:25 ---
(In reply to comment #16)
(In reply to comment #14)
> * Each package must consistently use macros, as described in the macros section
> of Packaging Guidelines .
> Please make use of the %{name} macro extensively (except maybe URL), or do not
> use it at all.
>
Hmm, I don't understand well, where I exactly did not use %{name} macro, except
at renaming and renamed binaries...
Yes, that's what I'm talking about (In %install and in %files sections).
The thing is, macros have to be used consistently. Either use %{name}
everywhere or mlt everywhere.
I prefer the former one.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:14 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #18 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-16 17:14:22 ---
(In reply to comment #15)
*
>* src/modules/jackrack/plugin_mgr.c has
> /usr/local/lib/ladspa:/usr/lib/ladspa
>hardcoded, which won't work on 64bit systems. Please fix this.
The same would be needed for frei0r-plugins
Which file? Why do you think so?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:05 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #19 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-16 22:05:39 ---
Here is the answer from MLT developer about renaming binaries:
Citation:
Please, can you look at:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=527
If you rename executables, esp. inigo, it will break kdenlive and
confuse users. A rename is coming very soon, but I don't plan to
follow Fedora's guidelines. The next version will have this new name
(melt) and get rid of miracle in the mlt package. Maybe we can make a
change in kdenlive to use different executable names to deal with this
upcoming change and Fedora's decision to rename everything.
So, I suggest that we do not renaming MLT binaries in spec file. Kdenlive is
primary application which using MLT, and we can not allow that renamed MLT
breaks kdenlive!
This is answer about 64bit problems in MLT:
Citation:
I can add paths for ladspa 64bit plugins as already. I will also
change usage of lqt-config to pkg-config.
I will ask Den for some patches because I will not package SVN releases, only
stables!
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:16 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #20 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-16 22:16:46 ---
Well, you can match kdenlive to use the correct binaries if that's the problem.
Just out of curiousity, how many miracles do we have in Fedora? :)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:45 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #21 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-16 22:45:56 ---
(In reply to comment #20)
Well, you can match kdenlive to use the correct binaries if
that's the problem.
Yes, but isn't is a so-called "bypass". Renaming original binaries file
names
is dangerous because we are losing original file names, and if someone want to
use MLT for his own development, than can be confused with un-original file
names of binaries.
So, I still think that abandon renaming in spec file is better solution.
Just out of curiousity, how many miracles do we have in Fedora? :)
Many! This is one of the reasons why I like Fedora :)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:53 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #22 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-16 22:53:02 ---
(In reply to comment #21)
So, I still think that abandon renaming in spec file is better solution.
I'm fine with that. I don't think "miracle" is too common of a name.
There are
many more common names we already have, like "/usr/bin/play" of the sox
package, or "/usr/bin/convert" of ImageMagick.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:02 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #23 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-16 23:02:03 ---
I'm fine with that. I don't think "miracle" is too common of a name.
There are
many more common names we already have, like "/usr/bin/play" of the sox
package, or "/usr/bin/convert" of ImageMagick.
OK than, I will exclude renaming from spec file.
BTW, with miracle we have Segmentation fault, and Dan said that it will be
exclude in this version of MLT (what is not happened).
I can exclude "miracle" from package until Dan resolve this binary in next SVN.
I can patch MLT than....
Or, if you have some better solution?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:18 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #24 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-17 01:18:21 ---
(In reply to comment #23)
I can exclude "miracle" from package until Dan resolve this binary in next
SVN.
I can patch MLT than....
Or, if you have some better solution?
I don't know what it does, or whether disabling it will affect kdenlive. If the
impact will be minimal, you can disable it for now, and patch it up when it is
fixed.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:32 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #25 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-17 05:32:44 ---
* I also missed this: These lines
# Don't optimize (breaks debugging)
sed -i -e '/fomit-frame-pointer/d' configure
sed -i -e '/ffast-math/d' configure
should go to %prep
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:18 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #26 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-17 13:18:07 ---
(In reply to comment #14)
* src/modules/jackrack/plugin_mgr.c has
/usr/local/lib/ladspa:/usr/lib/ladspa
hardcoded, which won't work on 64bit systems. Please fix this.
This can be resoved with setting enviornment LADSPA_PATH variable to correct
value:
export LADSPA_PATH=%{_libdir}/ladspa
in %install section, because program, at run-time check this variable, and it
will set internal variable to hardcoded only if LADSPA_PATH is empty!
# clear-execstack
execstack -c $RPM_BUILD_ROOT%{_libdir}/%{name}/libmltgtk2.so
This is necessary, else rpmlint gives warning...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:27 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #27 from NicolasChauvet <kwizart(a)gmail.com> 2009-04-17 13:27:04 ---
(In reply to comment #26)
(In reply to comment #14)
>
> * src/modules/jackrack/plugin_mgr.c has
> /usr/local/lib/ladspa:/usr/lib/ladspa
> hardcoded, which won't work on 64bit systems. Please fix this.
>
>
This can be resoved with setting enviornment LADSPA_PATH variable to correct
value:
This is not acceptable, please DO patch the source in order to have the
correct
multilib 64bit dso path by default.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:29 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #28 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-17 13:29:23 ---
(In reply to comment #27)
(In reply to comment #26)
> (In reply to comment #14)
>
> >
> > * src/modules/jackrack/plugin_mgr.c has
> > /usr/local/lib/ladspa:/usr/lib/ladspa
> > hardcoded, which won't work on 64bit systems. Please fix this.
> >
> >
> This can be resoved with setting enviornment LADSPA_PATH variable to correct
> value:
This is not acceptable, please DO patch the source in order to have the correct
multilib 64bit dso path by default.
Why is not acceptable?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:45 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #29 from Kevin Kofler <kevin.kofler(a)chello.at> 2009-04-17 15:45:35 ---
Because it's your job as a packager to make things work out of the box.
Requiring the user to set environment variables is just plain not acceptable.
You could set them in /etc/profile.d, but that's a suboptimal solution because
the new environment variables will only be picked up by newly-started shells,
so the software doesn't work right after installation. Patching the source code
is the more robust solution.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:52 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #30 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-17 15:51:58 ---
(In reply to comment #26)
(In reply to comment #14)
>
> * src/modules/jackrack/plugin_mgr.c has
> /usr/local/lib/ladspa:/usr/lib/ladspa
> hardcoded, which won't work on 64bit systems. Please fix this.
>
>
This can be resoved with setting enviornment LADSPA_PATH variable to correct
value:
export LADSPA_PATH=%{_libdir}/ladspa
in %install section, because program, at run-time check this variable, and it
will set internal variable to hardcoded only if LADSPA_PATH is empty!
and what will set the LADSPA_PATH during runtime? No, just patch (or sed) it
up, and there won't be no worries.
> # clear-execstack
> execstack -c $RPM_BUILD_ROOT%{_libdir}/%{name}/libmltgtk2.so
This is necessary, else rpmlint gives warning...
Please describe me the steps to get this rpmlint warning, with that line
removed.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:07 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #31 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-17 16:07:18 ---
and what will set the LADSPA_PATH during runtime? No, just patch (or sed) it
up, and there won't be no worries.
My mistake...
but if I put in spec some like this:
%post
/sbin/ldconfig
export LADSPA_PATH=%{_libdir}/ladspa
Then, will yum after installing package execute this export line and setup
LADSPA_PATH to correct value?
But if you want patch, I'll make a patch, but before them I must know how to
solve this multilib path (Currently I do not have enough knowledge about
multilibs :( ) (Nobody is perfect :) )
Please describe me the steps to get this rpmlint warning, with that line
removed.
After building package with mock and checked packages under mocsk's result dirs
with rpmlint, and without execstack line, I'm getting this warning in i386
package:
mlt.i586: W: executable-stack /usr/lib/mlt/libmltgtk2.so
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:12 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #32 from Rex Dieter <rdieter(a)math.unl.edu> 2009-04-17 16:12:07 ---
Re:%post hack for env variables
That'll set it only for the *install* environment, not runtime for all users.
ie, won't work (as-is). fixing properly as suggested is a much preferred route
to take.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:14 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #33 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-17 16:14:27 ---
(In reply to comment #32)
Re:%post hack for env variables
That'll set it only for the *install* environment, not runtime for all users.
ie, won't work (as-is). fixing properly as suggested is a much preferred route
to take.
OK, thanks, now I understand...
I'll go in battle with patching this.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:09 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #34 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-17 17:09:30 ---
(In reply to comment #31)
>
> and what will set the LADSPA_PATH during runtime? No, just patch (or sed) it
> up, and there won't be no worries.
My mistake...
but if I put in spec some like this:
%post
/sbin/ldconfig
export LADSPA_PATH=%{_libdir}/ladspa
Then, will yum after installing package execute this export line and setup
LADSPA_PATH to correct value?
But if you want patch, I'll make a patch, but before them I must know how to
solve this multilib path (Currently I do not have enough knowledge about
multilibs :( ) (Nobody is perfect :) )
It's okay, you learn with experience. It will be enough to change the line
ladspa_path = g_strdup ("/usr/local/lib/ladspa:/usr/lib/ladspa");
in src/modules/jackrack/plugin_mgr.c to
ladspa_path = g_strdup
("/usr/local/lib/ladspa:/usr/lib/ladspa:/usr/local/lib64/ladspa:/usr/lib64/ladspa");
You can then send this patch upstream.
>
> Please describe me the steps to get this rpmlint warning, with that line
> removed.
>
After building package with mock and checked packages under mocsk's result dirs
with rpmlint, and without execstack line, I'm getting this warning in i386
package:
mlt.i586: W: executable-stack /usr/lib/mlt/libmltgtk2.so
I confirm this to happen only in i386 package. x86_64 doesn't have the problem.
You can use the attached patch to solve the issue permanently. You can send
this upstream too.
Other then these, I found that the installed package gives the rpmlint
mlt.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmlt.so.0.3.8
/lib64/libm.so.6
which can easily be fixed too. Check the LDFLAGS.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:10 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #35 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-17 17:10:50 ---
Created an attachment (id=163)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=163)
adds .note.GNU-stack section
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:26 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #36 from NicolasChauvet <kwizart(a)gmail.com> 2009-04-17 17:26:02 ---
(In reply to comment #34)
...
It's okay, you learn with experience. It will be enough to change
the line
ladspa_path = g_strdup ("/usr/local/lib/ladspa:/usr/lib/ladspa");
in src/modules/jackrack/plugin_mgr.c to
ladspa_path = g_strdup
("/usr/local/lib/ladspa:/usr/lib/ladspa:/usr/local/lib64/ladspa:/usr/lib64/ladspa");
I would have picked lib64 first on lib64 system (and eventually on lib system
also since the lib64 directory may not exist which is less important than
trying to load a 32bit dso from a 64bit program.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:40 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #37 from Dan Horák <dan(a)danny.cz> 2009-04-17 17:40:03 ---
(In reply to comment #36)
(In reply to comment #34)
...
> It's okay, you learn with experience. It will be enough to change the line
> ladspa_path = g_strdup ("/usr/local/lib/ladspa:/usr/lib/ladspa");
> in src/modules/jackrack/plugin_mgr.c to
> ladspa_path = g_strdup
>
("/usr/local/lib/ladspa:/usr/lib/ladspa:/usr/local/lib64/ladspa:/usr/lib64/ladspa");
I would have picked lib64 first on lib64 system (and eventually on lib system
also since the lib64 directory may not exist which is less important than
trying to load a 32bit dso from a 64bit program.
I would use "sed -i 's|/usr/lib|%{_libdir}|'" on that file or a
get_plugin_dir()-like function from a library (if possible).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:43 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #38 from Kevin Kofler <kevin.kofler(a)chello.at> 2009-04-17 17:43:53 ---
Searching both lib and lib64 won't work if both the 32-bit and the 64-bit
version of the library are installed.
The correct solution is to write a patch which looks *only* in the lib64
directories, then apply it with:
%if "%{_lib}" == "lib64"
%patch0 -p1 -b .lib64
%endif
It can also be done with a sed as Dan Horák suggests. And no, this cannot be
upstreamed.
The only way upstream can handle this is to set some #define based on the
libdir detected by the build system (autotools in this case).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:44 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #39 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-17 17:44:55 ---
(In reply to comment #36)
(In reply to comment #34)
...
> It's okay, you learn with experience. It will be enough to change the line
> ladspa_path = g_strdup ("/usr/local/lib/ladspa:/usr/lib/ladspa");
> in src/modules/jackrack/plugin_mgr.c to
> ladspa_path = g_strdup
>
("/usr/local/lib/ladspa:/usr/lib/ladspa:/usr/local/lib64/ladspa:/usr/lib64/ladspa");
I would have picked lib64 first on lib64 system (and eventually on lib system
also since the lib64 directory may not exist which is less important than
trying to load a 32bit dso from a 64bit program.
You mean two patches, one for lib and one for lib64 system?
So, first will change:
ladspa_path = g_strdup
("/usr/local/lib/ladspa:/usr/lib/ladspa:/usr/local/lib64/ladspa:/usr/lib64/ladspa");
and second (lib64):
ladspa_path = g_strdup
("/usr/local/lib64/ladspa:/usr/lib64/ladspa:/usr/local/lib/ladspa:/usr/lib/ladspa");
or I miss your thoughts :)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:48 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #40 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-17 17:48:36 ---
(In reply to comment #38)
Searching both lib and lib64 won't work if both the 32-bit and
the 64-bit
version of the library are installed.
The correct solution is to write a patch which looks *only* in the lib64
directories, then apply it with:
%if "%{_lib}" == "lib64"
%patch0 -p1 -b .lib64
%endif
and in this case patch must change this:
ladspa_path = g_strdup
("/usr/local/lib/ladspa:/usr/lib/ladspa");
into this:
ladspa_path = g_strdup
("/usr/local/lib64/ladspa:/usr/lib64/ladspa");
is that correctly?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:52 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #41 from Kevin Kofler <kevin.kofler(a)chello.at> 2009-04-17 17:52:31 ---
Yes, that's what I mean.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:55 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #42 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-17 17:55:24 ---
(In reply to comment #38)
Searching both lib and lib64 won't work if both the 32-bit and
the 64-bit
version of the library are installed.
This is the plugin directory. No ladspa or lv2 plugins are multilib in Fedora.
I doubt that they will ever be. The patch will work. sed will work too. It's a
matter of taste.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:28 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #43 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-18 00:28:00 ---
! All relevant doc files should be packaged.
./src/modules/motion_est/README
can go to the %doc of the main package
How I can elegantly solve this?
I tried with this:
%doc AUTHORS ChangeLog COPYING GPL NEWS README motion_est
src/modules/motion_est/README
but I'm getting this error (what is logically), so how I can create subdir with
%doc, like in -devel example (%doc doc/* demos):
cp: will not overwrite just-created
`/builddir/build/BUILDROOT/mlt-0.3.8-2.fc10.i386/usr/share/doc/mlt-0.3.8/README'
with `src/modules/motion_est/README'
I was finding this explanations in Guidelines and other packaging
documentations, but nothing found!
* Please add BuildRequires: frei0r-devel
In Fedora 10 frei0r-devel do not exist (in F11 exist!)
* rawhide buildlog says:
- libquicktime not found: only enabling dv avi support
You need to patch this up so it can find the libquicktime properly.
I'm little confusing with this. What exactly I must patch? In F10 build.log do
not report "not found" problem (only in F11)
* Running mlt-miracle gives "segmentation fault"
I asked for this, but the answer is little weird.
Citation:
2) Can we exclude miracle from MLT (is that action break kdenlive)?
kdenlive does not need miracle, but currently the way the source is
structured, mlt++ includes the miracle and valerie classes, which
depends on the respective libs, and kdenlive uses mlt++. It is like a
knot at the moment :-/
Because
miracle gives Segmentation fault and this warning:
mlt.i386: W: shared-lib-calls-exit /usr/lib/libmiracle.so.0.3.7
Why does it say 0.3.7 instead of 0.3.8?
exit(a)GLIBC_2.0
You told me that it will be exclude in this version, so if this is not so
I said it will be done on the _next_ release.
simply to exclude, can you make some patch?
No, it is not trivial. The next release will be done as soon as I
reorganize the source trees and stabilize the build.
Many things make me a little headache, but I'll survive :)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:26 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #44 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-18 01:26:46 ---
(In reply to comment #43)
> ! All relevant doc files should be packaged.
./src/modules/motion_est/README
> can go to the %doc of the main package
How I can elegantly solve this?
Quite simple actually,
in %install:
mv src/modules/motion_est/README README.motion_est
and in %files:
%doc AUTHORS ChangeLog COPYING GPL NEWS README*
> * Please add BuildRequires: frei0r-devel
In Fedora 10 frei0r-devel do not exist (in F11 exist!)
It does exist in F-10. It is in the testing repo (for now).
>
> * rawhide buildlog says:
> - libquicktime not found: only enabling dv avi support
>
>
> You need to patch this up so it can find the libquicktime properly.
>
I'm little confusing with this. What exactly I must patch? In F10 build.log do
not report "not found" problem (only in F11)
That is because libquicktime in F-11 does not have lqt-config.
Patch it up to use pkg-config instead. It will be compatible for both F-10 and
F-11.
>
> * Running mlt-miracle gives "segmentation fault"
I asked for this, but the answer is little weird.
Citation:
> 2) Can we exclude miracle from MLT (is that action break kdenlive)?
kdenlive does not need miracle, but currently the way the source is
structured, mlt++ includes the miracle and valerie classes, which
depends on the respective libs, and kdenlive uses mlt++. It is like a
knot at the moment :-/
> Because
> miracle gives Segmentation fault and this warning:
>
I built kdenlive from the SRPM's you provided. kdenlive also gives me
segfaults. I didn't try to debug it yet, but perhaps it is related to this
miracle issue.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:29 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #45 from Kevin Kofler <kevin.kofler(a)chello.at> 2009-04-18 01:29:17 ---
How I can elegantly solve this?
[snip]
cp: will not overwrite just-created
`/builddir/build/BUILDROOT/mlt-0.3.8-2.fc10.i386/usr/share/doc/mlt-0.3.8/README'
with `src/modules/motion_est/README'
In %prep:
mv -f src/modules/motion_est/README src/modules/motion_est/README.motion_est
then in %files:
%doc src/modules/motion_est/README.motion_est
An alternative is to explicitly install your documentation in %install with any
path structure you like, then you can list the installed documentation:
%doc %{_docdir}/%{name}-%{version}/
In Fedora 10 frei0r-devel do not exist (in F11 exist!)
It's in updates-testing now.
I'm little confusing with this. What exactly I must patch? In F10
build.log do
not report "not found" problem (only in F11)
You apparently need to use pkg-config libquicktime instead of lqt-config.
That said, IMHO libquicktime should be shipping an lqt-config which calls
pkg-config, that has been done in several packages in Fedora to prevent
multilib conflicts. Dropping lqt-config entirely makes the package incompatible
with upstream and is a really bad idea. I reopened the libquicktime bug to
complain about that.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:42 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #46 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-18 23:42:14 ---
Here are the newest files:
Spec:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SPECS/mlt.spec
SRPM:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SRPMS/mlt-0.3.8-2.fc10.s...
I resolved mostly all review items except next:
* Other then these, I found that the installed package gives the rpmlint
mlt.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmlt.so.0.3.8
/lib64/libm.so.6
I will... :) (must a study this a little bit)
*Segmentation faults at miracle and inigo binaries.
This is something hard to resolve by myself. I'll must contact author...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:50 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #47 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-20 01:50:21 ---
The package looks a lot better in shape now. The remaining problems are:
1- shared-lib-calls-exit
2- the segfaults
3- unused-direct-shlib-dependency
You could do the fixes yourself but I think these are rather upstream's job.
When are they making the next release?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:22 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #48 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-04-20 08:22:57 ---
(In reply to comment #47)
The package looks a lot better in shape now. The remaining problems
are:
1- shared-lib-calls-exit
2- the segfaults
3- unused-direct-shlib-dependency
You could do the fixes yourself but I think these are rather upstream's job.
When are they making the next release?
One interesting thing!
At F11 miracle and inigo do NOT produce Segmentation faults !!
I know that MLT and kdenlive needs Qt library for work, the differences between
F10 (Qt 4.5 is not yet in official repo) and F11 is in Qt version, and in the
kernel itself...
I know that people complained for Kdenlive's crashes in F10, but not in F11...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:28 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #49 from Dan Horák <dan(a)danny.cz> 2009-04-20 08:28:18 ---
(In reply to comment #47)
The package looks a lot better in shape now. The remaining problems
are:
1- shared-lib-calls-exit
I usually ask upstream whether it is intended behaviour
2- the segfaults
3- unused-direct-shlib-dependency
see
https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#u...
You could do the fixes yourself but I think these are rather upstream's job.
When are they making the next release?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:15 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #50 from Kevin Kofler <kevin.kofler(a)chello.at> 2009-04-21 05:15:15 ---
If the package was built against Qt 4.5, it won't run against 4.4.
This is going to become a non-issue very soon as Qt 4.5 is now queued for
stable.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:09 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #51 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-01 15:09:48 ---
Huh, some new infos about MLT and Segmentation faults under F10.
I successfully localize a problem.
So, this Faults happens only if build MLT with ffmpeg-devel package.
Without ffmpeg (avformat option in MLT) inigo and miracle binaries do not
reports Seg. faults.
Why?
I do not know, maybe the problem laying somewhere under ffmpeg package, and not
under MLT???
To recall, this does not happen on Fedora 11!
If we do not solve this problem, can we build MLT and Kdenlive only for F11
branch (at least until we find a solution for the F10)?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:15 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #52 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-05-01 19:15:44 ---
So, mlt is not compatible with older versions of ffmpeg. Then it's okay if you
are going to submit it to F-11+.
The unused-direct-shlib-dependency can probably be fixed by
sed -i -e 's| -lm | -Wl,--as-needed\0|' src/framework/Makefile
in %prep. This is inspired by:
http://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#un...
The remaining issue is shared lib calls exit, which upstream promised to fix
(any news on this?)
Otherwise, after the above unused-direct-shlib-dep fix, I guess we can approve
the package if there are no objections.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:18 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #53 from Kevin Kofler <kevin.kofler(a)chello.at> 2009-05-07 04:18:36 ---
IMHO we'll want the kdenlive stack at least on F10 too (F9 is almost EOL, so
maybe not worth bothering), so I think we really need a solution for the
mlt/ffmpeg issue (though it shouldn't block the review as long as it doesn't
crash on F11).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:20 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #54 from Kevin Kofler <kevin.kofler(a)chello.at> 2009-05-07 04:20:48 ---
Oh, and can you please produce a backtrace for those segfaults, using GDB
and/or Valgrind?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:33 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #55 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-07 09:33:15 ---
(In reply to comment #52)
So, mlt is not compatible with older versions of ffmpeg. Then
it's okay if you
are going to submit it to F-11+.
My primary target is F11, but I want also try to resolve Seg faults for F10! :)
The unused-direct-shlib-dependency can probably be fixed by
I made this fix to the latest .spec and src:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SPECS/mlt.spec
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SRPMS/mlt-0.3.8-3.fc11.s...
So please, can you try this build?
The remaining issue is shared lib calls exit, which upstream promised to fix
(any news on this?)
I asked at upstream to resolve this problem (third time :) ) and I'm waiting
for answer.
Otherwise, after the above unused-direct-shlib-dep fix, I guess we can approve
the package if there are no objections.
I agree with this. I want to close this saga :) (but I will totally happy when
resolve F10 branch)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:24 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #56 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-07 13:24:43 ---
(In reply to comment #52)
The unused-direct-shlib-dependency can probably be fixed by
sed -i -e 's| -lm | -Wl,--as-needed\0|' src/framework/Makefile
in %prep. This is inspired by:
This fix actually do not work properly!
Rpmlint do not report warning, but this fix produces error when I try call
miracle binary:
F10-x86_64 arch:
mlt_repository_init: failed to dlopen /usr/lib64/mlt/libmltmotion_est.so
(/usr/lib64/mlt/libmltmotion_est.so: undefined symbol: sqrt)
F10-i386 arch:
mlt_repository_init: failed to dlopen /usr/lib/mlt/libmltplus.so
(/usr/lib/mlt/libmltplus.so: undefined symbol: sincos)
mlt_repository_init: failed to dlopen /usr/lib/mlt/libmlteffectv.so
(/usr/lib/mlt/libmlteffectv.so: undefined symbol: sin)
mlt_repository_init: failed to dlopen /usr/lib/mlt/libmltcore.so
(/usr/lib/mlt/libmltcore.so: undefined symbol: floor)
F10-x86_64 arch:
mlt_repository_init: failed to dlopen /usr/lib64/mlt/libmlteffectv.so
(/usr/lib64/mlt/libmlteffectv.so: undefined symbol: sin)
NO MORE Seg. faults on F10 branch with my machine! (I do not know why) So,
please can you check this, too?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:02 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #57 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-05-07 21:02:43 ---
(In reply to comment #56)
Rpmlint do not report warning, but this fix produces error when I try call
miracle binary:
F10-x86_64 arch:
mlt_repository_init: failed to dlopen /usr/lib64/mlt/libmltmotion_est.so
(/usr/lib64/mlt/libmltmotion_est.so: undefined symbol: sqrt)
Then we will need to make sure we pass the flags in the correct order and
position. Something like:
gcc -Wl,--as-needed someunit1.o someunit2.o -lm -o program
(From http://www.gentoo.org/proj/en/qa/asneeded.xml )
I think it will be best to write a patch for this and send it upstream.
NO MORE Seg. faults on F10 branch with my machine! (I do not know why) So,
please can you check this, too?
I still get the segfaults on F-10.
gdb output:
(gdb) run
Starting program: /usr/bin/miracle
[Thread debugging using libthread_db enabled]
[New Thread 0x7ffff79896f0 (LWP 7341)]
Detaching after fork from child process 7424.
bind: Address already in use
Program received signal SIGSEGV, Segmentation fault.
0x00000032b6e1288d in fini_context_translations () at setrans_client.c:243
243 free(prev_r2t_trans);
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:20 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #58 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-07 22:20:06 ---
> NO MORE Seg. faults on F10 branch with my machine! (I do not
know why) So,
> please can you check this, too?
>
I still get the segfaults on F-10.
Yes, at home I get segfaults too, but on VBox machine at work do not.
I'll check again tomorrow.
I have answers from upstream too, but author of MLT do not like Fedora to much
:(
Citations:
On Wed, May 6, 2009 at 11:17 PM, Zarko Pintar <zarko.pintar(a)gmail.com> wrote:
1st) You suggested to me to try disable SELinux, but my SELinux is
disabled!
2nd) If I use ffmpeg drom SVN (not from RPM FUsion repo), than I'm getting
Segmentation Faults from that ffmpeg!
Oh well, I do not use Fedora 10 or 11. I have enough to do already.
Are you telling me that you can't find one Fedora user to figure this
out and send a patch to the relevant project? If you can't then that
is an indicator of just how unpopular Fedora is as a distro for MLT
users, which means it really isn't worth my time right now. I have
better things to do, such as...
For this reason I ask you again, can you make some patch for MLT 0.38
for
resolving this build warning:
mlt.i386: W: shared-lib-calls-exit /usr/lib/libmiracle.so.0.3.7
exit(a)GLIBC_2.0
I already repeatedly gave the answer to this. I am not willing to
apply a patch that removes these calls because it will break the
functionality. I have clients that have paid me money that uses this
code, and I am not going to fuck it up for them. However, Fedora is
free to apply their own patch since miracle is not interesting to most
of its users. There is no simple patch to reorganize the repo and
remove miracle from the mlt project. I am already in the process of
reorganizing, but it is far from trivial. I might be able to get this
done this weekend.
So, what are you guys suggest to do now??
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:51 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Orcan Ogetbil <oget.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |2
--- Comment #59 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-05-07 22:51:32 ---
What a ...
A segfault is always a bug. And even a newbie programmer should know that a
shared library shouldn't call exit() unless there is a compelling reason and he
doesn't show any. If he's willing to deliver a buggy software to his paying
clients, just let him do it.
I'm not going to write a patch after such a response. In fact, I'm not willing
to support this guy and I'm resigning from the review. If there's anyone who
wants to take it over, be my guest. Zarko, please don't take this personal. You
did your best.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:12 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #60 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-08 08:12:09 ---
(In reply to comment #59)
I'm not going to write a patch after such a response. In fact, I'm not willing
to support this guy and I'm resigning from the review. If there's anyone who
wants to take it over, be my guest. Zarko, please don't take this personal. You
did your best.
Yes, I agree with you and your stands. I'll continue make builds for Fedora 11
on my private Fedora repo, and tests F10 builds (for people who like Fedora and
need Kdenlive), until someone wants to make patches or something, or until
"Mr." Dan reset yourself and takes these bugs away from MLT.
Until that, Live long and prosper :)
Zarko
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:41 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Dan Dennedy <dan(a)dennedy.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dan(a)dennedy.org
--- Comment #61 from Dan Dennedy <dan(a)dennedy.org> 2009-05-08 19:41:03 ---
Dear Zarko and Orcan,
I am sorry if my comments offended you. It may be known to some that I am not
particularly fond of some Fedora policies. However, I have also expressed that
I do respect the good intention and effort of the Fedora project. The goal here
is to make kdenlive, which is receiving praises, readily available to Fedora
users. Allow me to propose that we not let us not let our emotions from getting
in the way of that. I really have been trying to address the issues raised ever
since this process started in Fedora proper.
Let me address the technical issues:
1) Calling exit() in a shared lib.
The reason this exists is historical and somewhat "complicated.". The short
story is that libmiracle (where this exists), miracle, and some other parts are
legacy baggage from the context of kdenlive and other forthcoming apps (GTK+
OpenShot) simply wanting to use MLT core. Therefore, to address this and some
other issues, I have chosen to remove this baggage (libmiracle, miracle, and
some others) from the next release of mlt. The work is complete, and I hope to
finish testing and make a new release within a week.
2) Strange, mixed license comments in mlt++ source.
Yep, another thing I inherited and overlooked ever since. This is being
addressed as part of the fore-mentioned reorganization because that process
also involves folding mlt++ into mlt.
3) unused-direct-shlib-dependency (libmlt linking to libm) and plugins
underlinking libm.
I have not yet addressed it, but I will.
4) "A segfault is always a bug."
Of course, but I am not reproducing this on any of my systems. One of them (a
mirror of a few customers' system) runs F8 and is working. And kdenlive users
on other distros have no startup segfault like this. I am trying to focus on
the above issues and request help from Fedora users and devs to locate this bug
that seems to be triggered specifically in this environment and/or method of
build.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:45 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #62 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-08 23:45:16 ---
(In reply to comment #61)
Dear Zarko and Orcan,
I am sorry if my comments offended you. It may be known to some that I am not
particularly fond of some Fedora policies. However, I have also expressed that
I do respect the good intention and effort of the Fedora project. The goal here
is to make kdenlive, which is receiving praises, readily available to Fedora
users. Allow me to propose that we not let us not let our emotions from
I accept your apology, and I hope that it will accept and Orcan.
I'm always on the user's side and it is not good that users suffer because of
this.
So, if Orcan agree with me, I want to continue work on packaking MLT and
Kdenlive.
BTW, my idea is to primary concentrate to:
1) Calling exit() in a shared lib.
2) Strange, mixed license comments in mlt++ source.
3) unused-direct-shlib-dependency (libmlt linking to libm) and plugins
and secondary to:
4) "A segfault is always a bug."
Because F11 do not have Segfaults issue, but have 1), 2) and 3), and my opinion
is builds primary for F11, and than for F10 branch.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:27 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #63 from Kevin Kofler <kevin.kofler(a)chello.at> 2009-05-09 00:27:11 ---
I don't see how calling exit() from a shared lib would be a review blocker!
rpmlint warns about it because it is not a nice thing to do, but:
* this is an upstream issue,
* in most cases, changing it is an API change,
* there are plenty of libraries in Fedora which call exit,
so this is not a valid reason to block the review at all.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:33 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #64 from Dan Dennedy <dan(a)dennedy.org> 2009-05-10 07:33:53 ---
Zarko,
Please adapt the RPM spec to my newly organized source tree and test it. You
need to first git clone git://dennedy.org/mlt.git. If you want to make a
mlt-0.3.9.tar.gz, then just run 'make dist'
Be sure to read these important notes about this reorganization:
http://www.mltframework.org/twiki/bin/view/MLT/ExtremeMakeover
The key things for you are that mlt++ is not a separate packago, inigo -> melt,
and miracle is gone. Also, this version addresses issues 1 - 3 from your last
message. If all goes well, it will be released as v0.4.0 around May 15, but I
do not want to release it until it appears these Fedora issues have been
addressed.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:32 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #65 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-11 14:32:22 ---
(In reply to comment #64)
Zarko,
Please adapt the RPM spec to my newly organized source tree and test it. You
need to first git clone git://dennedy.org/mlt.git. If you want to make a
mlt-0.3.9.tar.gz, then just run 'make dist'
It's finished.
Here:
spec:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SPECS/mlt.spec
SRPM:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SRPMS/mlt-0.3.9-1.fc11.s...
In short preview we have some new issues.
1) i386 architecture builds (F10, F11)
* mlt.i586: W: executable-stack /usr/lib/mlt/libmltgtk2.so
like in previous version it resolved by the attached patch:
adds .note.GNU-stack section
Maybe is better than Dan include this patch to upstream source.
* mlt.i586: E: shlib-with-non-pic-code /usr/lib/libmlt++.so.0.3.9
can be solved. Look at link:
http://fedoraproject.org/wiki/Common_Rpmlint_issues#shlib-with-non-pic-code
2) x86_64 architecture builds (F10, F11)
* Build fails!
Can not build, reported this error:
g++ -shared -Wl,-soname,libmlt++.so.1 -o libmlt++.so.0.3.9 MltConsumer.o
MltDeque.o MltEvent.o MltFactory.o MltField.o MltFilter.o MltFilteredConsumer.o
MltFrame.o MltGeometry.o MltMultitrack.o MltParser.o MltPlaylist.o
MltProducer.o MltProfile.o MltProperties.o MltPushConsumer.o MltRepository.o
MltService.o MltTokeniser.o MltTractor.o MltTransition.o -Wl,--as-needed
-L../framework -lmlt
/usr/bin/ld: MltConsumer.o: relocation R_X86_64_32 against `a local symbol' can
not be used when making a shared object; recompile with -fPIC
MltConsumer.o: could not read symbols: Bad value
collect2: ld returned 1 exit status
make[1]: Leaving directory `/builddir/build/BUILD/mlt-0.3.9/src/mlt++'
RPM build errors:
make[1]: *** [libmlt++.so.0.3.9] Error 1
make: *** [all] Error 1
lib64 and libquicktime bugs are resolved in source now, so no patches needed.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:01 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #66 from Kevin Kofler <kevin.kofler(a)chello.at> 2009-05-11 15:01:09 ---
This:
/usr/bin/ld: MltConsumer.o: relocation R_X86_64_32 against `a local
symbol' can
not be used when making a shared object; recompile with -fPIC
is the same bug as this:
* mlt.i586: E: shlib-with-non-pic-code /usr/lib/libmlt++.so.0.3.9
except that it fails to link on x86_64, and pretty much any architecture other
than 32-bit x86. Code in shared libraries must be PIC.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #67 from Dan Dennedy <dan(a)dennedy.org> 2009-05-11 20:00:02 ---
I have applied the noexec-stack patch and added PIC flags to the building of
libmlt++. Please update!
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:01 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #68 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-11 23:01:16 ---
(In reply to comment #67)
I have applied the noexec-stack patch and added PIC flags to the
building of
libmlt++. Please update!
I am.
For now, under i386 architecture no more rpmlint issues, but SegFaults exist:
This is gdb out:
Program received signal SIGSEGV, Segmentation fault.
0x00a887c4 in ?? () from /lib/libselinux.so.1
That is all what gdb reports to me.
Tomorrow I'll try to build x86_64 arch.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:11 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #69 from Dan Dennedy <dan(a)dennedy.org> 2009-05-12 09:11:24 ---
If you ask gdb for a backtrace or 'where' you get nothing more? If so, please
send me the command you are running and the strace output.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:34 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #70 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-12 11:34:15 ---
(In reply to comment #69)
If you ask gdb for a backtrace or 'where' you get nothing
more? If so, please
send me the command you are running and the strace output.
This is a backtrace:
(gdb) bt
#0 0x0097f7c4 in ?? () from /lib/libselinux.so.1
#1 0x0097893e in ?? () from /lib/libselinux.so.1
#2 0x00970f88 in selinux_file_context_cmp () from /lib/libselinux.so.1
#3 0x00988ed4 in selinux_file_context_cmp () from /lib/libselinux.so.1
#4 0x0806c7f8 in ?? ()
#5 0x0806c7f0 in ?? ()
#6 0x00970f2a in selinux_file_context_cmp () from /lib/libselinux.so.1
#7 0x00988ff4 in selinux_file_context_cmp () from /lib/libselinux.so.1
#8 0x0806a660 in ?? ()
#9 0xbfffece8 in ?? ()
#10 0x009818c0 in _fini () from /lib/libselinux.so.1
Backtrace stopped: frame did not save the PC
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:41 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #71 from Dan Horák <dan(a)danny.cz> 2009-05-12 11:41:15 ---
(In reply to comment #70)
(In reply to comment #69)
> If you ask gdb for a backtrace or 'where' you get nothing more? If so,
please
> send me the command you are running and the strace output.
>
This is a backtrace:
(gdb) bt
#0 0x0097f7c4 in ?? () from /lib/libselinux.so.1
#1 0x0097893e in ?? () from /lib/libselinux.so.1
#2 0x00970f88 in selinux_file_context_cmp () from /lib/libselinux.so.1
#3 0x00988ed4 in selinux_file_context_cmp () from /lib/libselinux.so.1
#4 0x0806c7f8 in ?? ()
#5 0x0806c7f0 in ?? ()
#6 0x00970f2a in selinux_file_context_cmp () from /lib/libselinux.so.1
#7 0x00988ff4 in selinux_file_context_cmp () from /lib/libselinux.so.1
#8 0x0806a660 in ?? ()
#9 0xbfffece8 in ?? ()
#10 0x009818c0 in _fini () from /lib/libselinux.so.1
Backtrace stopped: frame did not save the PC
Zarko, you should install at least mlt-debuginfo (directly with rpm) and
debuginfos for libselinux (via "debuginfo-install libselinux") to get somewhat
better backtraces.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:01 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #72 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-12 12:01:08 ---
(In reply to comment #71)
Zarko, you should install at least mlt-debuginfo (directly with rpm)
and
debuginfos for libselinux (via "debuginfo-install libselinux") to get somewhat
better backtraces.
Ah, sorry. Here is better one...
(gdb) bt
#0 0x0097f7c4 in fini_context_translations () at setrans_client.c:243
#1 0x0097893e in fini_lib () at init.c:127
#2 0x00970f88 in __do_global_dtors_aux () from /lib/libselinux.so.1
#3 0x009818c0 in _fini () from /lib/libselinux.so.1
#4 0x0072fb87 in _dl_close_worker (map=0x8063d78) at dl-close.c:271
#5 0x007304b7 in _dl_close (_map=0x8063d78) at dl-close.c:730
#6 0x008b9cc4 in dlclose_doit (handle=0x8063d78) at dlclose.c:37
#7 0x00729db6 in _dl_catch_error (objname=0x80533d4, errstring=0x80533d8,
mallocedp=0x80533d0,
operate=0x8b9ca0 <dlclose_doit>, args=0x8063d78) at dl-error.c:178
#8 0x008ba05c in _dlerror_run (operate=0x8b9ca0 <dlclose_doit>, args=<value
optimized out>) at dlerror.c:164
#9 0x008b9cfa in __dlclose (handle=0x8063d78) at dlclose.c:48
#10 0x004e44bb in mlt_property_clear () at mlt_property.c:107
#11 mlt_property_close (this=0x806f430) at mlt_property.c:475
#12 0x004e4ee3 in mlt_properties_close (this=0x8051f48) at
mlt_properties.c:1161
#13 0x004f423e in mlt_repository_close (this=0x8051f48) at mlt_repository.c:236
#14 0x004f3746 in mlt_factory_close () at mlt_factory.c:368
#15 0x08049ee5 in mlt_profile_close () at mlt_profile.c:294
#16 0x007596e5 in __libc_start_main (main=0x8049a30 <mlt_profile_close+1904>,
argc=1, ubp_av=0xbffff344, init=0x804ad90,
fini=0x804ad80, rtld_fini=0x72a6d0 <_dl_fini>, stack_end=0xbffff33c) at
libc-start.c:220
#17 0x080492f1 in mlt_profile_close () at mlt_profile.c:294
(gdb)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:03 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #73 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-12 12:03:23 ---
And, this is from gdb, but before backtrace:
Program received signal SIGSEGV, Segmentation fault.
0x0097f7c4 in fini_context_translations () at setrans_client.c:243
243 free(prev_r2t_trans);
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:16 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #74 from Kevin Kofler <kevin.kofler(a)chello.at> 2009-05-12 14:16:58 ---
Ah, this appears to be the same crash on exit we're seeing with KDE 3 apps
using ffmpeg (Kaffeine and K3b with the -freeworld plugins installed). We've
tracked it down to something calling close(-1) which is an invalid file
descriptor to pass to close, but we haven't figured out where exactly that is
being passed.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:03 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #75 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-12 15:03:51 ---
(In reply to comment #74)
Ah, this appears to be the same crash on exit we're seeing with
KDE 3 apps
using ffmpeg (Kaffeine and K3b with the -freeworld plugins installed). We've
tracked it down to something calling close(-1) which is an invalid file
descriptor to pass to close, but we haven't figured out where exactly that is
being passed.
Hmm, but there is no crashes on upcoming F11. Why?
What is so different between this two branches?
Kernel, SELinux, GCC, or something else?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:04 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #76 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-13 09:04:11 ---
Here is the latest build:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SPECS/mlt.spec
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SRPMS/mlt-0.3.9-2.fc11.s...
There is no rpmlint issues. Seems to be clean, now.
Still remaining Segfaults at F10.
So, what is next?
Do we want build this for F11, and continue finding F10 bug, or what?
Dan,
In the source we still have two licenses (GPL and LGPL) but which is right?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:17 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #77 from Dan Dennedy <dan(a)dennedy.org> 2009-05-13 10:17:20 ---
In the source we still have two licenses (GPL and LGPL) but which is
right?
Both. libmlt, libmlt++, and some modules are LGPL. Some other modules and melt
are GPL. The GPL modules must be enabled using --enable-gpl. If you are
installing of this as one package, then you should indicate the package as GPL.
This does not contradict what was recently fixed. There were comment headers in
mlt++ that said LGPL but also incorrectly stated "... You should have received
a copy of the GNU General Public License," which is what was fixed.
Next steps for me are to release this. I already provided a patch for kdenlive
to deal with mlt changes.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:33 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #78 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-13 10:33:59 ---
(In reply to comment #77)
Next steps for me are to release this. I already provided a patch for kdenlive
to deal with mlt changes.
Ok, than I'm waiting for some Fedora's reviewer to tell how to package this
(wait for F10 resolving and than package for F10 and F11, or package for F11
and than resolving F10 issue).
From my point of view, these segfaults aren't a matter of MLT, but
prior of
ffmpeg or something else...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:07 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #79 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-18 15:07:35 ---
Stable release of MLT 0.4.0 is out
Here is the latest build:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SPECS/mlt.spec
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SRPMS/mlt-0.4.0-1.fc11.s...
Someone to review this? (after all of this job)
rpmlint still is clean :)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:35 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #80 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-05-20 07:35:34 ---
Upon Zarko's personal request I had a look at this last version of the package.
- The license tag is fine. Some parts of the software is GPL, some part is
LGPL.
* The segfault on F-10 persists (just run /usr/bin/mlt)
* There are these undefined symbols that need attention:
$ ldd -r `rpm -ql mlt|grep so$`|grep undefined
undefined symbol: sqrt (/usr/lib64/mlt/libmltmotion_est.so)
undefined symbol: floor (/usr/lib64/mlt/libmltmotion_est.so)
So -lm needs to be passed to the linker for this .so file.
* I am not able to make builds on ppc/ppc64. I see this
#if defined (ARCH_PPC) && defined (ENABLE_ALTIVEC)
on src/modules/xine/cpu_accel.c but I don't see where the ARCH_PPC and
ENABLE_ALTIVEC are defined. It might be good to make use of altivec in these
architectures for better performance. Maybe you need to pass an extra
"-DARCH_PPC -DENABLE_ALTIVEC" to the compiler on ppc/ppc64? Please ask upstream
about this (why they don't define ARCH_PPC and ENABLE_ALTIVEC anywhere).
* The file /usr/include/mlt++/config.h from mlt-devel has the weird mixed
license clause. If the actual license of this file is LGPL and the demo/
directory is LGPL, then the devel subpackage will be just LGPL. This needs
clarified.
The rest seems fine.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:44 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #81 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-20 08:44:14 ---
(In reply to comment #80)
* The segfault on F-10 persists (just run /usr/bin/mlt)
Yes, but please can you read Kevin's comment (comment #74) about this
segfaults. He compared this bug with K3b's segfault on exit.
So, maybe this segfault isn't MLT's bug, but ffmpeg's...
* There are these undefined symbols that need attention:
$ ldd -r `rpm -ql mlt|grep so$`|grep undefined
undefined symbol: sqrt (/usr/lib64/mlt/libmltmotion_est.so)
undefined symbol: floor (/usr/lib64/mlt/libmltmotion_est.so)
So -lm needs to be passed to the linker for this .so file.
Hmm, I found this in makefile
======================================
include ../../../config.mak
TARGET = ../libmltmotion_est.so
OBJS = factory.o \
filter_motion_est.o \
filter_crop_detect.o \
filter_autotrack_rectangle.o \
arrow_code.o \
filter_vismv.o \
producer_slowmotion.o
CFLAGS += -I../..
------------------------------------
LDFLAGS += -L../../framework -lmlt
------------------------------------
SRCS := $(OBJS:.o=.c)
all: $(TARGET)
=======================================
LDFLAGS has -lmlt option enabled for this library, or I'm seeing something
completely wrong, or -lmlt and -lm isn't same (I think that's -lmlt is the same
as -lm -lt)?!
* I am not able to make builds on ppc/ppc64. I see this
#if defined (ARCH_PPC) && defined (ENABLE_ALTIVEC)
In configure exist this option:
=============================================================================
--arch='arch' - Compile for a specific architecture (default: none)
=============================================================================
Maybe this can help, but I'll ask upstream ;)
* The file /usr/include/mlt++/config.h from mlt-devel has the weird mixed
license clause. If the actual license of this file is LGPL and the demo/
directory is LGPL, then the devel subpackage will be just LGPL. This needs
clarified.
I'll ask, too.
Thanks for your returning to review :)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:46 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #82 from Jussi Lehtola <jussi.lehtola(a)iki.fi> 2009-05-20 09:46:57 ---
(In reply to comment #81)
LDFLAGS has -lmlt option enabled for this library, or I'm seeing
something
completely wrong, or -lmlt and -lm isn't same (I think that's -lmlt is the same
as -lm -lt)?!
No, it is not. -lm links against libm.so which is the standard math library,
-lmlt links against libmlt.so which is the mlt library.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:57 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #83 from Dan Dennedy <dan(a)dennedy.org> 2009-05-20 09:57:05 ---
I fixed the linking of libmltmotionest.so with libm, and I fixed the license in
the comment header in src/mlt++/config.h to be consistent with the rest of the
files in that dir. These are in my git repo.
As for the PPC failure, I need some help to track down the issue.
src/modules/xine/cpu_accel.c is not supposed to be compiled for ppc even though
it might be possible. The reason is that this code was copied from the xine
project, but it does not share the same build system to set all of the flags
(and we do not have ppc machines to test and debug the accellerated plugin if
we could). Rather, the mlt build simply tries to prevent building any of the
asm for ppc. It does try to detect if mmx is available automatically, but it
will certainly fail if you are cross-compiling on an intel arch machine. Can
you try passing --disable-mmx and --disable-sse to configure for the ppc build?
If it still fails, then please try to get the generated config.mak in the top
level directory, if possible, and attach it here. Otherwise, can you provide
more info?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:01 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #84 from Dan Dennedy <dan(a)dennedy.org> 2009-05-20 10:01:05 ---
Also, there is no "license" for the demo/ directory. It's mainly just
example
command lines.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:28 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #85 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-20 10:28:01 ---
(In reply to comment #83)
Can
you try passing --disable-mmx and --disable-sse to configure for the ppc build?
Yeah, I did.
Here are new files:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SPECS/mlt.spec
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SRPMS/mlt-0.4.0-2.fc11.s...
I added this to spec:
===================================================
%ifarch ppc ppc64
--disable-mmx \
--disable-sse \
%endif
===================================================
I can not test this because I do not have PPC machine...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:11 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #86 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-05-20 19:11:54 ---
Zarko,
Could you backport the -lm and the config.h license patches from the trunk?
http://mltframework.org/gitweb/mlt.git?p=mltframework.org/mlt.git;a=commi...
http://mltframework.org/gitweb/mlt.git?p=mltframework.org/mlt.git;a=commi...
Now, we need to set the license tag for the devel subpackage to LGPLv2+.
I don't have a ppc/ppc64 machine. I think that the ALTIVEC question will wait
for its answer until we have someone to do the tests.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:42 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #87 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-20 22:42:59 ---
(In reply to comment #86)
Zarko,
Could you backport the -lm and the config.h license patches from the trunk?
Now, we need to set the license tag for the devel subpackage to
LGPLv2+.
Done.
Here:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SPECS/mlt.spec
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SRPMS/mlt-0.4.0-3.fc10.s...
I don't have a ppc/ppc64 machine. I think that the ALTIVEC question will wait
for its answer until we have someone to do the tests.
It's mean that we do not build packages for PPC and PPC64 architectures now?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:31 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Orcan Ogetbil <oget.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2, 30 |3
--- Comment #88 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-05-21 22:31:53 ---
Thanks Dan and Zarko. I think this is the best we can do for the time being.
Zarko, it is a good practice to add a comment for each patch and additional
source file (if there's any), indicating what it is for and giving a link to
the upstream bugtracker and/or to the respective commit from the trunk. Could
you add these comments?
I am removing your sponsorship request (bug #30) since you are already
sponsored in Fedora.
Because there are so many people involved in this bug, I'll wait 48 hours
before I approve the package.
Please reason your objection if you have any.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:53 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #89 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-21 22:53:03 ---
(In reply to comment #88)
Thanks Dan and Zarko. I think this is the best we can do for the time
being.
Thanks to you, too. :)
Zarko, it is a good practice to add a comment for each patch and additional
source file (if there's any), indicating what it is for and giving a link to
the upstream bugtracker and/or to the respective commit from the trunk. Could
you add these comments?
Yes I can, but I explained these patches in Changelog section of spec file:
====================================================
%changelog
* Wed May 20 2009 Zarko Pintar <zarko.pintar(a)gmail.com> - 0.4.0-3
- added linker patch to fix link motionest against libm
- added license patch to fix license info of MLT++
- set license of MLT devel subpackage to LGPLv2+
====================================================
I am removing your sponsorship request (bug #30) since you are already
sponsored in Fedora.
O, thanks....
Please reason your objection if you have any.
? What with PPC??
Can we build this package on PPC architecture or not, after last spec
intervention?
Or I must put
ExcludeArch: PPC, PPC64
? What with segfaults under F10?
Will we build only for F11, or...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:14 p.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #90 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-05-21 23:14:54 ---
(In reply to comment #89)
(In reply to comment #88)
>
> Zarko, it is a good practice to add a comment for each patch and additional
> source file (if there's any), indicating what it is for and giving a link
> to the upstream bugtracker and/or to the respective commit from the trunk.
> Could you add these comments?
Yes I can, but I explained these patches in Changelog section of spec file:
I meant, commenting about the patches/additional sources where you actually
declare them
See for instance:
http://cvs.rpmfusion.org/viewvc/rpms/traverso/devel/traverso.spec?root=fr...
? What with PPC??
Can we build this package on PPC architecture or not, after last spec
intervention?
Or I must put
ExcludeArch: PPC, PPC64
No, please don't exclude them. Let us see how things go when you do the builds.
? What with segfaults under F10?
Will we build only for F11, or...
I would request cvs for all of them but do not build on dists < F-11 until the
segfault issue is resolved.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:08 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #91 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-22 12:08:03 ---
(In reply to comment #90)
I meant, commenting about the patches/additional sources where you
actually
declare them
Okay, I fixed this now, see:
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SPECS/mlt.spec
http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SRPMS/mlt-0.4.0-3.fc11.s...
I would request cvs for all of them but do not build on dists < F-11 until the
segfault issue is resolved.
Understandable...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:45 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Orcan Ogetbil <oget.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--- Comment #92 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-05-24 03:45:22 ---
Since there are no complaints...
---------------------------------------------------------
This package (mlt) is APPROVED by oget for rpmfusion-free
---------------------------------------------------------
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:45 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Zarko Pintar <zarko.pintar(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #93 from Zarko Pintar <zarko.pintar(a)gmail.com> 2009-05-24 13:45:43 ---
Package CVS request
======================
Package Name: mlt
Short Description: Toolkit for broadcasters, video editors, media players,
transcoders
Owners: grof
Branches: F10 F11
InitialCC: grof
----------------------
License tag: free
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:57 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--- Comment #94 from Thorsten Leemhuis <fedora(a)leemhuis.info> 2009-05-24 13:57:41
---
(In reply to comment #93)
Package CVS request
done
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:21 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
Martin Strigl <mst(a)friendlynet.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mst(a)friendlynet.at
--- Comment #95 from Martin Strigl <mst(a)friendlynet.at> 2009-05-27 09:21:40 ---
(In reply to comment #92)
Since there are no complaints...
---------------------------------------------------------
This package (mlt) is APPROVED by oget for rpmfusion-free
---------------------------------------------------------
i know i'm a little bit late, but i've got a complaint. i used the src rpm from
zarko
(http://wiki.open.hr/~zpintar/fedora-11/RPMFusion/SRPMS/mlt-0.4.0-3.fc11.s...)
to rebuild on my system (2.6.29.3-140.fc11.i686.PAE #1 SMP Tue May 12 10:44:10
EDT 2009 i686 i686 i386 GNU/Linux).
it aborts the build as soon as it tries to compile the mlt++ part -- i get a
bunch full of "error: stray '#' in program" compilation errors.
i found a solution, but i'm not quite sure whether it's correct. so i'll post
it here just to let you know.
[seldon@morpheus SPECS]$ cat ../SOURCES/mlt-0.4.0.dDPIC.diff
diff -ruNp mlt-0.4.0.orig/src/mlt++/configure
mlt-0.4.0.edit/src/mlt++/configure
--- mlt-0.4.0.orig/src/mlt++/configure 2009-05-18 06:23:53.000000000 +0200
+++ mlt-0.4.0.edit/src/mlt++/configure 2009-05-26 13:49:33.000000000 +0200
@@ -13,7 +13,7 @@ case $targetos in
;;
Linux|FreeBSD)
echo LIBSUF=.so
- echo "CXXFLAGS+=-Wall $WARNINGS -fPIC -dPIC"
+ echo "CXXFLAGS+=-Wall $WARNINGS -fPIC -DPIC"
echo "LIBFLAGS=-shared"
;;
esac >> config.mak
mfg,
martin
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:34 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #96 from Dan Dennedy <dan(a)dennedy.org> 2009-05-27 09:34:12 ---
Thank you for finding and reporting that stupid typo. I have fixed it upstream.
Zarko, I expect there will be a 0.4.2 version shortly.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:37 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #97 from Zarko Pintar (grof) <zarko.pintar(a)gmail.com> 2009-05-27
09:37:37 ---
(In reply to comment #96)
Thank you for finding and reporting that stupid typo. I have fixed it
upstream.
Zarko, I expect there will be a 0.4.2 version shortly.
:) You are so fast, man....
OK, than I do not patch current version, just build new one when arrives.
Thanks Martin for bug report, Thanks Dan for quick reply.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:40 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #98 from Zarko Pintar (grof) <zarko.pintar(a)gmail.com> 2009-05-27
09:40:45 ---
and a little note:
I do not want to close this bug threat until we find a solution for F10
segfaults.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:41 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #99 from Martin Strigl <mst(a)friendlynet.at> 2009-05-27 10:41:00 ---
(In reply to comment #97)
(In reply to comment #96)
> Thank you for finding and reporting that stupid typo. I have fixed it upstream.
>
> Zarko, I expect there will be a 0.4.2 version shortly.
>
:) You are so fast, man....
OK, than I do not patch current version, just build new one when arrives.
Thanks Martin for bug report, Thanks Dan for quick reply.
you're welcome
just out of curiosity, how did you manage to compile without this typo fixed ?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:46 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #100 from Zarko Pintar (grof) <zarko.pintar(a)gmail.com> 2009-05-27
10:46:08 ---
(In reply to comment #99)
just out of curiosity, how did you manage to compile without this typo fixed ?
Honestly, I do not know. Just passed in Mock...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:10 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
--- Comment #101 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-05-27 11:10:58
---
I find it weird that it didn't fail to build on my computer or on rpmfusion's
buildsys:
http://buildsys.rpmfusion.org/logs/fedora-development-rpmfusion_free/4013...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:56 a.m.
New subject: [Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
http://bugzilla.rpmfusion.org/show_bug.cgi?id=527
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #102 from NicolasChauvet <kwizart(a)gmail.com> 2009-07-09 13:56:07 ---
mlt is in, closing the review
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5405
days inactive
5497
days old
rpmfusion-developers@lists.rpmfusion.org
105 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla