7:18 a.m.
On Thursday, 21 April 2011 at 03:56, Richard Shaw wrote:
[...]
Modified Files:
avidemux.spec
Log Message:
* Wed Apr 20 2011 Richard Shaw <hobbes1069(a)gmail.com> - 2.5.4-4
- Disabled non-working patch for experimental aac encoding with ffmpeg.
- Removed dependency on bundled javascript library. Now uses system library.
- Added optional opencore-amr decoding support.
I noticed that you enabled support for system js library, but I don't see
any BuildRequires added for it (maybe Requires too?).
Also please ensure that your patches don't contain cosmetic changes
(whitespace, empty lines, etc.). It makes them smaller and easier
to review.
Regards,
Dominik
--
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
-- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
1:11 p.m.
New subject: rpms/avidemux/devel avidemux.spec,1.40,1.41
On Thu, Apr 21, 2011 at 2:18 AM, Dominik 'Rathann' Mierzejewski
<dominik(a)greysector.net> wrote:
On Thursday, 21 April 2011 at 03:56, Richard Shaw wrote:
[...]
> Modified Files:
> avidemux.spec
> Log Message:
> * Wed Apr 20 2011 Richard Shaw <hobbes1069(a)gmail.com> - 2.5.4-4
> - Disabled non-working patch for experimental aac encoding with ffmpeg.
> - Removed dependency on bundled javascript library. Now uses system library.
> - Added optional opencore-amr decoding support.
I noticed that you enabled support for system js library, but I don't see
any BuildRequires added for it (maybe Requires too?).
It was already a BR but the cmake configure script doesn't pick it up
automatically. I had to add the cmake option
"-DUSE_SYSTEM_SPIDERMONKEY".
Also please ensure that your patches don't contain cosmetic
changes
(whitespace, empty lines, etc.). It makes them smaller and easier
to review.
I'm not sure what happened there. I didn't edit any of the patches
manually, the ones I created were the direct output of diff, however,
one of the patches I got from the avidemux *nix fourms.
Richard
5:26 p.m.
New subject: rpms/avidemux/devel avidemux.spec,1.40,1.41
- Disabled non-working patch for experimental aac encoding with
ffmpeg.
Uhm, I wrote that patch… We need to figure out why this is not working.
Without that patch, you don't get AAC support at all, because we can't build
against faac which is in nonfree. There have been complaints about lack of
AAC support. Interestingly, nobody complained about the AAC support with the
patch not working.
Unfortunately, I'm not sure I'll have the time to test and debug this
though.
Kevin Kofler
5:50 p.m.
New subject: rpms/avidemux/devel avidemux.spec,1.40,1.41
On Thu, Apr 21, 2011 at 12:26 PM, Kevin Kofler <kevin.kofler(a)chello.at> wrote:
> - Disabled non-working patch for experimental aac encoding with
ffmpeg.
Uhm, I wrote that patch… We need to figure out why this is not working.
Without that patch, you don't get AAC support at all, because we can't build
against faac which is in nonfree. There have been complaints about lack of
AAC support. Interestingly, nobody complained about the AAC support with the
patch not working.
I had previously put in a bug for the crash:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1659
But this was while avidemux was not being actively maintained.
When you have time take a look and let me know if the error output helps.
Thanks,
Richard
12:11 a.m.
New subject: rpms/avidemux/devel avidemux.spec,1.40,1.41
Richard Shaw wrote:
I had previously put in a bug for the crash:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1659
But this was while avidemux was not being actively maintained.
When you have time take a look and let me know if the error output helps.
Yes. This is an assertion failure because the codec is not being built in
the bundled FFmpeg. (Bundled libraries suck!) See my comment in the bug
report for how to fix this.
Kevin Kofler
7:42 p.m.
New subject: rpms/avidemux/devel avidemux.spec,1.40,1.41
On Thu, Apr 21, 2011 at 12:26 PM, Kevin Kofler <kevin.kofler(a)chello.at> wrote:
> - Disabled non-working patch for experimental aac encoding with
ffmpeg.
Uhm, I wrote that patch… We need to figure out why this is not working.
Without that patch, you don't get AAC support at all, because we can't build
against faac which is in nonfree. There have been complaints about lack of
AAC support. Interestingly, nobody complained about the AAC support with the
patch not working.
Forgot to ask.
For clarification, when you say no AAC support at all. Do you mean
decode as well? I would think faad2 would cover that, right?
Thanks,
Richard
11:25 p.m.
New subject: rpms/avidemux/devel avidemux.spec,1.40,1.41
Richard Shaw wrote:
For clarification, when you say no AAC support at all. Do you mean
decode as well? I would think faad2 would cover that, right?
No, sorry, I mean no AAC encode support at all.
Yes, decoding is supported by Free libraries (not sure if faad2 or FFmpeg is
being used, but both are Free).
FAAD was rewritten as FAAD2 to eliminate the copyright-license-encumbered
code from the MPEG reference implementation, but unfortunately the same was
never done to FAAC and this problem was noticed only fairly recently (by the
FFmpeg folks, who are very careful about licensing).
Kevin Kofler
4755
days inactive
4756
days old
rpmfusion-developers@lists.rpmfusion.org
6 comments
3 participants
participants (3)
-
Dominik 'Rathann' Mierzejewski -
Kevin Kofler -
Richard Shaw