Re: rpms/avidemux/devel avidemux.spec,1.40,1.41
On Thu, Apr 21, 2011 at 2:18 AM, Dominik 'Rathann' Mierzejewski
<dominik(a)greysector.net> wrote:
On Thursday, 21 April 2011 at 03:56, Richard Shaw wrote:
[...]
> Modified Files:
> avidemux.spec
> Log Message:
> * Wed Apr 20 2011 Richard Shaw <hobbes1069(a)gmail.com> - 2.5.4-4
> - Disabled non-working patch for experimental aac encoding with ffmpeg.
> - Removed dependency on bundled javascript library. Now uses system library.
> - Added optional opencore-amr decoding support.
I noticed that you enabled support for system js library, but I don't see
any BuildRequires added for it (maybe Requires too?).
It was already a BR but the cmake configure script doesn't pick it up
automatically. I had to add the cmake option
"-DUSE_SYSTEM_SPIDERMONKEY".
Also please ensure that your patches don't contain cosmetic
changes
(whitespace, empty lines, etc.). It makes them smaller and easier
to review.
I'm not sure what happened there. I didn't edit any of the patches
manually, the ones I created were the direct output of diff, however,
one of the patches I got from the avidemux *nix fourms.
Richard