9:06 a.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
Bug ID: 4285
Summary: Review request: telegram-desktop - Telegram Desktop
official client
Product: Package Reviews
Version: Current
Hardware: x86_64
OS: GNU/Linux
Status: NEW
Severity: enhancement
Priority: P1
Component: Review Request
Assignee: rpmfusion-package-review(a)rpmfusion.org
Reporter: vitaly(a)easycoding.org
CC: rpmfusion-package-review(a)rpmfusion.org
URL: https://github.com/telegramdesktop/tdesktop
Description:
Telegram is a messaging app with a focus on speed and security, it’s super
fast, simple and free. You can use Telegram on all your devices at the same
time — your messages sync seamlessly across any of your phones, tablets or
computers.
SPEC: https://github.com/xvitaly/tgbuild/raw/master/telegram-desktop.spec
SRPM:
http://koji.russianfedora.pro/kojifiles/packages/telegram-desktop/0.10.11...
Additional information:
Built against patched by Telegram Desktop Developers static Qt 5.6.0. Telegram
Desktop can not build and run without this patches.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
10:08 a.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
leigh scott <leigh123linux(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |leigh123linux(a)gmail.com
Blocks| |2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
10:15 a.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #1 from leigh scott <leigh123linux(a)gmail.com> ---
I don't see you listed here
https://fas.rpmfusion.org/
Please create an account
I note that your are a fedora packager so no sponsor needed
https://admin.fedoraproject.org/accounts/user/view/xvitaly
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
1:03 p.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #2 from Vitaly Zaitsev <vitaly(a)easycoding.org> ---
I don't see you listed here
Created RPMFusion FAS account: xvitaly
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
10:02 a.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #3 from leigh scott <leigh123linux(a)gmail.com> ---
Please use the proper fedora build flags and make all builds verbose.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
12:32 p.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #4 from Vitaly Zaitsev <vitaly(a)easycoding.org> ---
Please use the proper fedora build flags
I don't know how to do that because Telegram Desktop use GYP, which overrides
exported by RPM build CXXFLAGS and LDFLAGS.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
12:34 p.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #5 from Vitaly Zaitsev <vitaly(a)easycoding.org> ---
Override specified in
https://github.com/telegramdesktop/tdesktop/blob/v0.10.11/Telegram/gyp/te...
(lines 65 - 93).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
1:56 p.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #6 from leigh scott <leigh123linux(a)gmail.com> ---
(In reply to Vitaly Zaitsev from comment #5)
Override specified in
https://github.com/telegramdesktop/tdesktop/blob/v0.10.11/Telegram/gyp/
telegram_linux.gypi#L66 (lines 65 - 93).
Try patching the file to this (untested)
'configurations': {
'Release': {
'cflags': [
'$(RPM_OPT_FLAGS)',
],
'cflags_cc': [
'$(RPM_OPT_FLAGS)',
],
'ldflags': [
'$(RPM_LD_FLAGS)',
],
},
},
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
3:18 p.m.
On Thu, Oct 06, 2016 at 09:06:22AM +0000, RPM Fusion Bugzilla wrote:
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
Bug ID: 4285
Summary: Review request: telegram-desktop - Telegram Desktop
official client
Telegram seem to be available in Flatpak. Do we need it in RPM?
--
Tomasz Torcz There exists no separation between gods and men:
xmpp: zdzichubg(a)chrome.pl one blends softly casual into the other.
7:35 p.m.
On Sáb, 2016-10-08 at 17:18 +0200, Tomasz Torcz wrote:
On Thu, Oct 06, 2016 at 09:06:22AM +0000, RPM Fusion Bugzilla wrote:
>
> http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
>
> Bug ID: 4285
> Summary: Review request: telegram-desktop - Telegram
> Desktop
> official client
Telegram seem to be available in Flatpak. Do we need it in RPM?
why we should use flatpak instead rpm ?
--
Sérgio M. B.
4:49 p.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #7 from Vitaly Zaitsev <vitaly(a)easycoding.org> ---
Try patching the file to this (untested)
cc: error: $(RPM_OPT_FLAGS): No such file or directory
c++: error: $(RPM_OPT_FLAGS): No such file or directory
c++: error: $(RPM_LD_FLAGS): No such file or directory
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
5:01 p.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #8 from leigh scott <leigh123linux(a)gmail.com> ---
(In reply to Vitaly Zaitsev from comment #7)
> Try patching the file to this (untested)
cc: error: $(RPM_OPT_FLAGS): No such file or directory
c++: error: $(RPM_OPT_FLAGS): No such file or directory
c++: error: $(RPM_LD_FLAGS): No such file or directory
Try removing the brackets from them
edit
$(RPM_OPT_FLAGS)
to
$RPM_OPT_FLAGS
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
5:11 p.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #9 from Vitaly Zaitsev <vitaly(a)easycoding.org> ---
Try removing the brackets from them
cc: error: RPM_OPT_FLAGS: No such file or directory
GYP doc:
https://chromium.googlesource.com/external/gyp/+/md-pages/docs/InputForma...
Trying also such:
'<!@(echo $CFLAGS)',
got another error:
Error evaluating generator expression: $<BOOL:-pipe -g -Wall -W -fPIC
-Wno-unused-result -Wno-unused-variable -Wno-unused-parameter
-Wno-unused-function -Wno-switch -Wno-comment -Wno-unused-but-set-variable
-Wno-missing-field-initializers -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -pipe -g
-Wall -W -fPIC -Wno-unused-result -Wno-unused-variable -Wno-unused-parameter
-Wno-unused-function -Wno-switch -Wno-comment -Wno-unused-but-set-variable
-Wno-missing-field-initializers -std=gnu++1y -pthread
-I/usr/include/libappindicator-0.1 -I/usr/include/libdbusmenu-glib-0.4
-I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16
-I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libpng16
-pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include
-I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo
-I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/libpng16 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz
-I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
-I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
-pthread -I/usr/include/dee-1.0 -I/usr/include/gio-unix-2.0/
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -O2 -g -pipe -Wall
-Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
6:18 p.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #10 from Vitaly Zaitsev <vitaly(a)easycoding.org> ---
It crashes at line 76:
https://github.com/telegramdesktop/tdesktop/blob/v0.10.11/Telegram/gyp/Pr...
Error evaluating generator expression: $<BOOL:-O2 -g -pipe -Wall...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
4:55 p.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
Nikos Roussos <comzeradd(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |comzeradd(a)fedoraproject.org
--- Comment #11 from Nikos Roussos <comzeradd(a)fedoraproject.org> ---
Isn't Telegram's client open source? Why this has to be on Rpmfusion?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
5:07 p.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #12 from Nicolas Chauvet <kwizart(a)gmail.com> ---
(In reply to Nikos Roussos from comment #11)
Isn't Telegram's client open source? Why this has to be on
Rpmfusion?
Because it relies upon ffmpeg-devel
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
12:50 p.m.
New subject: [Bug 4285] Review request: telegram-desktop - Telegram Desktop official client
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4285
--- Comment #13 from Vitaly Zaitsev <vitaly(a)easycoding.org> ---
Updated to version 0.10.19.
I think now it support exported CXXFLAGS even without patches:
cc1plus: warning:
/home/builder/rpmbuild/BUILD/tdesktop-0.10.19/out/Release/Telegram_pch/stdafx.h.gch/.c++:
not used because `_FORTIFY_SOURCE' is defined [-Winvalid-pch]
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
2746
days inactive
2765
days old
rpmfusion-developers@lists.rpmfusion.org
16 comments
3 participants
participants (3)
-
RPM Fusion Bugzilla -
Sérgio Basto -
Tomasz Torcz