5:48 a.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
Summary: Review request: picard-extras-freeworld - Acoustic
fingerprinting for Picard tagger
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: alexl(a)users.sourceforge.net
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Estimated Hours: 0.0
spec: http://alexlan.fedorapeople.org/rpmfusion/picard-extras-freeworld.spec
srpm:
http://alexlan.fedorapeople.org/rpmfusion/picard-extras-freeworld-0.11-2....
Picard is an audio tagging application using data from the MusicBrainz
database. This add-on package supplies the library necessary for
acoustic fingerprinting.
Why not Fedora: audio fingerprinting requires ffmpeg library which isn't able
to be in Fedora. This package restores the ffmpeg, which is a single shared
library "avcodec.so". This package simply restores that single file to the
Fedora base package "picard", and as I am also the Fedora maintainer, it will
be kept in sync with that package.
# rpmlint picard-extras-freeworld-0.11-2.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings
# rpmlint i386/picard-extras-freeworld-0.11-2.fc11.i386.rpm
picard-extras-freeworld.i386: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Warning can be ignored as all the docs are in the Fedora base package.
This is my first RPM Fusion package, and I am also an active Fedora maintainer:
http://fedoraproject.org/wiki/User:Alexlan
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:22 a.m.
New subject: [Bug 284] Review request: picard-extras-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
--- Comment #1 from Alex Lancaster <alexl(a)users.sourceforge.net> 2008-12-30
07:22:14 ---
Bug in Fedora bugzilla with more background on the need for the RPM Fusion
package:
http://bugzilla.redhat.com/show_bug.cgi?id=478354
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:35 p.m.
New subject: [Bug 284] Review request: picard-extras-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
--- Comment #2 from Kevin Kofler <kevin.kofler(a)chello.at> 2008-12-30 15:35:52 ---
cp $RPM_BUILD_ROOT%{python_sitearch}/picard/musicdns/avcodec.so
avcodec.so
This should be cp -p.
install avcodec.so $RPM_BUILD_ROOT%{python_sitearch}/picard/musicdns/
And likewise this should be install -p.
Timestamps are supposed to be preserved according to the guidelines. That said,
as this file is compiled anyway (so always gets a new timestamp), it doesn't
really matter in this case.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3 p.m.
New subject: [Bug 284] Review request: picard-extras-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
--- Comment #3 from NicolasChauvet <kwizart(a)gmail.com> 2008-12-30 16:00:50 ---
CHANGE -extras- seems too much. some packages are using it for optionals
plugins that aresn't ship with the "-core" sources archives.
NOTE - In general, it seems easier to have foo-freeworld than to think either
it is foo-plugin-?? or foo-extras-??
OK - Mock Build succeed with Fedora 10 i386
INVESTIGATE - why <avcodec.h> is tried whereas this is deprecated? Compat
headers shouldn't be even try when <libavcodec/avcodec.h> is found. (For info
the ffmpeg header move appeared in July 2008.)
------------
#include <avcodec.h>
gcc -pthread -fno-strict-aliasing -DNDEBUG -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -D_GNU_SOURCE -fPIC -fPIC -I/usr/include/ffmpeg -c
_configtest.c -o _configtest.o
_configtest.c:1:21:
error:
avcodec.h: No such file or directory
------------
CHANGE - I tend to agree with Kevin. It is always useful to prevent timestamp
changes. (even if it is compiled - maybe a binary could have been ship with the
source!) I would add that using the correct perms also help. (-pm 0755) that
would prevent default behavior that could appear when installing.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:23 p.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
Alex Lancaster <alexl(a)users.sourceforge.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Review request: picard- |Review request: picard-
|extras-freeworld - Acoustic |freeworld - Acoustic
|fingerprinting for Picard |fingerprinting for Picard
|tagger |tagger
--- Comment #4 from Alex Lancaster <alexl(a)users.sourceforge.net> 2009-01-02
22:23:25 ---
New spec: http://alexlan.fedorapeople.org/rpmfusion/picard-freeworld.spec
New SRPM:
http://alexlan.fedorapeople.org/rpmfusion/picard-freeworld-0.11-3.fc11.sr...
Note: renamed package as per comment #3.
* Fri Jan 2 2009 Alex Lancaster <alexlan[AT]fedoraproject org> - 0.11-3
- Rename to picard-freeworld as per review
- Fix cp/install commands
- Modified patch by Bob Arendt to skip test for <avcodec.h>
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:27 p.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
--- Comment #5 from Alex Lancaster <alexl(a)users.sourceforge.net> 2009-01-02
22:27:50 ---
This should also be in the "free" section of the repo.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:24 p.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
--- Comment #6 from Alex Lancaster <alexl(a)users.sourceforge.net> 2009-01-14
13:24:32 ---
Is there anything more I can to do to update the .spec file to push this review
along?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:15 p.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
--- Comment #7 from Andrea Musuruane <musuruan(a)gmail.com> 2009-01-14 14:15:05 ---
(In reply to comment #6)
Is there anything more I can to do to update the .spec file to push
this review
along?
To speed up the review, try swapping it with another pending request.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:48 p.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kwizart(a)gmail.com
--- Comment #8 from NicolasChauvet <kwizart(a)gmail.com> 2009-01-14 18:48:07 ---
I've miss the previous update.
OK - mock tested with Fedora 11 Rawhide x86
OK - debuginfo are extracted
NOTOK - do you know why make check failed at :
----------
from picard.similarity import similarity
File "/builddir/build/BUILD/picard-0.11/picard/similarity.py", line 22, in
<module>
from picard.util.astrcmp import astrcmp
ImportError
:
No module named astrcmp
+ :
+ exit 0
---------
Even if picard is installed, the test is failing. (unless i'm wrong).
Other than that, it looks OK...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:04 p.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3
AssignedTo|rpmfusion-package- |kwizart(a)gmail.com
|review(a)rpmfusion.org |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:15 a.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
--- Comment #9 from Alex Lancaster <alexl(a)users.sourceforge.net> 2009-01-15
05:15:35 ---
New spec: http://alexlan.fedorapeople.org/rpmfusion/picard-freeworld.spec
New SRPM:
http://alexlan.fedorapeople.org/rpmfusion/picard-freeworld-0.11-4.fc11.sr...
* Wed Jan 14 2009 Alex Lancaster <alexlan[AT]fedoraproject org> - 0.11-4
- Remove check target, only useful in the base picard package.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4:20 a.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
--- Comment #10 from Alex Lancaster <alexl(a)users.sourceforge.net> 2009-01-15
05:20:14 ---
(In reply to comment #8)
NOTOK - do you know why make check failed at :
----------
from picard.similarity import similarity
File "/builddir/build/BUILD/picard-0.11/picard/similarity.py", line 22, in
<module>
from picard.util.astrcmp import astrcmp
ImportError
:
No module named astrcmp
+ :
+ exit 0
---------
Even if picard is installed, the test is failing. (unless i'm wrong).
I don't think this test suite actually works properly upstream, so I don't see
any harm excluding it for the moment, in any case, this test suite is really
intended for the main base picard package, not this small subpackage.
The actual module does work in the base picard package when it's installed, so
there's some problem with finding in the path.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:25 a.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
--- Comment #11 from NicolasChauvet <kwizart(a)gmail.com> 2009-01-15 11:25:45 ---
-------------
This package (picard-freeworld) is APPROVED by me
------------
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:53 a.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
Alex Lancaster <alexl(a)users.sourceforge.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4, 33
--- Comment #12 from Alex Lancaster <alexl(a)users.sourceforge.net> 2009-01-15
11:53:21 ---
Package CVS request
======================
Package Name: picard-freeworld
Short Description: Acoustic fingerprinting for Picard tagger
Owners: alexlan
Branches: F-9, F-10
InitialCC:
----------------------
License tag: free
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5:39 p.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--- Comment #13 from Thorsten Leemhuis <fedora(a)leemhuis.info> 2009-01-15 18:39:03
---
(In reply to comment #12)
Package CVS request
======================
Package Name: picard-freeworld
Done
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:57 a.m.
New subject: [Bug 284] Review request: picard-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
Alex Lancaster <alexl(a)users.sourceforge.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|4 |
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #14 from Alex Lancaster <alexl(a)users.sourceforge.net> 2009-01-16
03:57:24 ---
Build on rawhide succeeded:
http://buildsys.rpmfusion.org/build-status/job.psp?email=alexl@users.sour...
Closing bug.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5588
days inactive
5605
days old
rpmfusion-developers@lists.rpmfusion.org
15 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla